Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Scheduler sampling profiler #20833

Closed

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Feb 17, 2021

Stacks on top of #20832

Removes Scheduler's integrated sampling profiler. I'm not aware of this being used within FB so we might as well kill it.

If I'm wrong and it's in use though, happy to just close this PR.

Alternative to #20831.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 17, 2021
@@ -217,17 +176,11 @@ function workLoop(hasTimeRemaining, initialTime) {
currentTask.callback = null;
currentPriorityLevel = currentTask.priorityLevel;
const didUserCallbackTimeout = currentTask.expirationTime <= currentTime;
markTaskRun(currentTask, currentTime);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had some unwrapped profiling method calls. Wonder if that was costing us bytes?

const continuationCallback = callback(didUserCallbackTimeout);
currentTime = getCurrentTime();
if (typeof continuationCallback === 'function') {
currentTask.callback = continuationCallback;
markTaskYield(currentTask, currentTime);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for calls to markTaskYield.

@bvaughn bvaughn changed the title Cleanup scheduler sampling profiler Remove scheduler sampling profiler Feb 17, 2021
@bvaughn bvaughn changed the title Remove scheduler sampling profiler Remove unused scheduler sampling profiler Feb 17, 2021
@bvaughn bvaughn changed the title Remove unused scheduler sampling profiler Remove unused Scheduler sampling profiler Feb 17, 2021
@sizebot
Copy link

sizebot commented Feb 17, 2021

Comparing: 8fa0ccc...8e50058

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.34 kB 122.34 kB = 39.40 kB 39.40 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 128.92 kB 128.92 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 404.81 kB 404.81 kB = 75.19 kB 75.19 kB
facebook-www/ReactDOM-prod.modern.js = 393.16 kB 393.16 kB = 73.28 kB 73.28 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.82 kB 404.82 kB = 75.19 kB 75.19 kB
oss-experimental/scheduler/umd/scheduler.development.js = 4.90 kB 4.74 kB = 0.87 kB 0.86 kB
oss-stable/scheduler/umd/scheduler.development.js = 4.90 kB 4.74 kB = 0.87 kB 0.86 kB
oss-experimental/scheduler/umd/scheduler.production.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-experimental/scheduler/umd/scheduler.profiling.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-stable/scheduler/umd/scheduler.production.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-stable/scheduler/umd/scheduler.profiling.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-experimental/react/umd/react.development.js = 112.14 kB 105.66 kB = 27.45 kB 26.07 kB
oss-stable/react/umd/react.development.js = 109.88 kB 103.39 kB = 27.04 kB 25.65 kB
oss-experimental/react/umd/react.profiling.min.js = 15.70 kB 14.24 kB = 5.85 kB 5.27 kB
oss-stable/react/umd/react.profiling.min.js = 14.65 kB 13.19 kB = 5.56 kB 4.97 kB
facebook-www/Scheduler-dev.classic.js = 25.50 kB 18.88 kB = 6.79 kB 5.36 kB
facebook-www/Scheduler-dev.modern.js = 25.50 kB 18.88 kB = 6.79 kB 5.36 kB
oss-experimental/scheduler/umd/scheduler-unstable_mock.development.js = 24.72 kB 18.23 kB = 5.71 kB 4.22 kB
oss-stable/scheduler/umd/scheduler-unstable_mock.development.js = 24.72 kB 18.23 kB = 5.71 kB 4.22 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.development.js = 23.06 kB 16.95 kB = 5.60 kB 4.12 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.development.js = 23.06 kB 16.95 kB = 5.60 kB 4.12 kB
facebook-react-native/scheduler/cjs/SchedulerMock-dev.js = 23.14 kB 16.99 kB = 5.61 kB 4.12 kB
facebook-www/SchedulerPostTaskOnly-dev.classic.js = 24.22 kB 17.62 kB = 6.41 kB 4.96 kB
facebook-www/SchedulerPostTaskOnly-dev.modern.js = 24.22 kB 17.62 kB = 6.41 kB 4.96 kB
facebook-www/SchedulerMock-dev.classic.js = 23.92 kB 17.32 kB = 5.69 kB 4.20 kB
facebook-www/SchedulerMock-dev.modern.js = 23.92 kB 17.32 kB = 5.69 kB 4.20 kB
oss-experimental/scheduler/cjs/scheduler.development.js = 22.20 kB 16.07 kB = 5.98 kB 4.55 kB
oss-stable/scheduler/cjs/scheduler.development.js = 22.20 kB 16.07 kB = 5.98 kB 4.55 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js = 22.29 kB 16.12 kB = 5.98 kB 4.55 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task_only.development.js = 21.75 kB 15.64 kB = 5.91 kB 4.49 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task_only.development.js = 21.75 kB 15.64 kB = 5.91 kB 4.49 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js = 14.12 kB 10.10 kB = 3.47 kB 2.60 kB
facebook-www/Scheduler-profiling.classic.js = 16.46 kB 11.37 kB = 3.85 kB 2.86 kB
facebook-www/Scheduler-profiling.modern.js = 16.46 kB 11.37 kB = 3.85 kB 2.86 kB
facebook-react-native/scheduler/cjs/SchedulerNoDOM-profiling.js = 12.57 kB 8.55 kB = 3.04 kB 2.15 kB
facebook-www/SchedulerPostTaskOnly-profiling.classic.js = 15.70 kB 10.63 kB = 3.71 kB 2.72 kB
facebook-www/SchedulerPostTaskOnly-profiling.modern.js = 15.70 kB 10.63 kB = 3.71 kB 2.72 kB
oss-experimental/scheduler/cjs/scheduler-unstable_no_dom.development.js = 18.89 kB 12.76 kB = 4.91 kB 3.44 kB
oss-stable/scheduler/cjs/scheduler-unstable_no_dom.development.js = 18.89 kB 12.76 kB = 4.91 kB 3.44 kB
facebook-react-native/scheduler/cjs/SchedulerNoDOM-dev.js = 18.90 kB 12.73 kB = 4.91 kB 3.42 kB
facebook-www/SchedulerNoDOM-dev.classic.js = 19.68 kB 13.05 kB = 5.00 kB 3.51 kB
facebook-www/SchedulerNoDOM-dev.modern.js = 19.68 kB 13.05 kB = 5.00 kB 3.51 kB
facebook-www/SchedulerNoDOM-profiling.classic.js = 13.90 kB 8.80 kB = 3.24 kB 2.23 kB
facebook-www/SchedulerNoDOM-profiling.modern.js = 13.90 kB 8.80 kB = 3.24 kB 2.23 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react/umd/react.production.min.js = 10.99 kB 10.97 kB = 4.42 kB 4.42 kB
facebook-www/SchedulerMock-prod.classic.js = 11.96 kB 11.93 kB = 2.84 kB 2.83 kB
facebook-www/SchedulerMock-prod.modern.js = 11.96 kB 11.93 kB = 2.84 kB 2.83 kB
facebook-react-native/scheduler/cjs/SchedulerMock-prod.js = 11.69 kB 11.66 kB = 2.76 kB 2.75 kB
facebook-www/Scheduler-prod.classic.js = 11.41 kB 11.37 kB = 2.87 kB 2.86 kB
facebook-www/Scheduler-prod.modern.js = 11.41 kB 11.37 kB = 2.87 kB 2.86 kB
facebook-www/SchedulerPostTaskOnly-prod.classic.js = 10.66 kB 10.63 kB = 2.73 kB 2.72 kB
facebook-www/SchedulerPostTaskOnly-prod.modern.js = 10.66 kB 10.63 kB = 2.73 kB 2.72 kB
facebook-react-native/scheduler/cjs/Scheduler-prod.js = 10.14 kB 10.10 kB = 2.61 kB 2.60 kB
facebook-www/SchedulerNoDOM-prod.classic.js = 8.83 kB 8.80 kB = 2.24 kB 2.23 kB
facebook-www/SchedulerNoDOM-prod.modern.js = 8.83 kB 8.80 kB = 2.24 kB 2.23 kB
facebook-react-native/scheduler/cjs/SchedulerNoDOM-prod.js = 8.58 kB 8.55 kB = 2.16 kB 2.15 kB
oss-experimental/scheduler/umd/scheduler-unstable_mock.production.min.js = 4.79 kB 4.76 kB = 2.01 kB 2.00 kB
oss-stable/scheduler/umd/scheduler-unstable_mock.production.min.js = 4.79 kB 4.76 kB = 2.01 kB 2.00 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.production.min.js = 4.74 kB 4.71 kB = 1.91 kB 1.90 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.production.min.js = 4.74 kB 4.71 kB = 1.91 kB 1.90 kB
oss-experimental/scheduler/cjs/scheduler.production.min.js = 4.33 kB 4.30 kB = 1.82 kB 1.80 kB
oss-stable/scheduler/cjs/scheduler.production.min.js = 4.33 kB 4.30 kB = 1.82 kB 1.80 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task_only.production.min.js = 4.08 kB 4.05 kB = 1.77 kB 1.75 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task_only.production.min.js = 4.08 kB 4.05 kB = 1.77 kB 1.75 kB
facebook-www/SchedulerPostTask-prod.classic.js = 4.07 kB 4.04 kB = 1.12 kB 1.11 kB
facebook-www/SchedulerPostTask-prod.modern.js = 4.07 kB 4.04 kB = 1.12 kB 1.11 kB
facebook-www/SchedulerPostTask-profiling.classic.js = 4.07 kB 4.04 kB = 1.12 kB 1.11 kB
facebook-www/SchedulerPostTask-profiling.modern.js = 4.07 kB 4.04 kB = 1.12 kB 1.11 kB
oss-experimental/scheduler/cjs/scheduler-unstable_no_dom.production.min.js = 3.54 kB 3.51 kB = 1.48 kB 1.47 kB
oss-stable/scheduler/cjs/scheduler-unstable_no_dom.production.min.js = 3.54 kB 3.51 kB = 1.48 kB 1.47 kB
facebook-www/SchedulerPostTask-dev.classic.js = 7.01 kB 6.90 kB = 2.11 kB 2.07 kB
facebook-www/SchedulerPostTask-dev.modern.js = 7.01 kB 6.90 kB = 2.11 kB 2.07 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.production.min.js = 1.98 kB 1.95 kB = 0.85 kB 0.84 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.production.min.js = 1.98 kB 1.95 kB = 0.85 kB 0.84 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task.development.js = 6.89 kB 6.78 kB = 2.09 kB 2.06 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task.development.js = 6.89 kB 6.78 kB = 2.09 kB 2.06 kB
oss-experimental/scheduler/umd/scheduler.development.js = 4.90 kB 4.74 kB = 0.87 kB 0.86 kB
oss-stable/scheduler/umd/scheduler.development.js = 4.90 kB 4.74 kB = 0.87 kB 0.86 kB
oss-experimental/scheduler/umd/scheduler.production.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-experimental/scheduler/umd/scheduler.profiling.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-stable/scheduler/umd/scheduler.production.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-stable/scheduler/umd/scheduler.profiling.min.js = 4.63 kB 4.48 kB = 0.87 kB 0.85 kB
oss-experimental/react/umd/react.development.js = 112.14 kB 105.66 kB = 27.45 kB 26.07 kB
oss-stable/react/umd/react.development.js = 109.88 kB 103.39 kB = 27.04 kB 25.65 kB
oss-experimental/react/umd/react.profiling.min.js = 15.70 kB 14.24 kB = 5.85 kB 5.27 kB
oss-stable/react/umd/react.profiling.min.js = 14.65 kB 13.19 kB = 5.56 kB 4.97 kB
facebook-www/Scheduler-dev.classic.js = 25.50 kB 18.88 kB = 6.79 kB 5.36 kB
facebook-www/Scheduler-dev.modern.js = 25.50 kB 18.88 kB = 6.79 kB 5.36 kB
oss-experimental/scheduler/umd/scheduler-unstable_mock.development.js = 24.72 kB 18.23 kB = 5.71 kB 4.22 kB
oss-stable/scheduler/umd/scheduler-unstable_mock.development.js = 24.72 kB 18.23 kB = 5.71 kB 4.22 kB
oss-experimental/scheduler/cjs/scheduler-unstable_mock.development.js = 23.06 kB 16.95 kB = 5.60 kB 4.12 kB
oss-stable/scheduler/cjs/scheduler-unstable_mock.development.js = 23.06 kB 16.95 kB = 5.60 kB 4.12 kB
facebook-react-native/scheduler/cjs/SchedulerMock-dev.js = 23.14 kB 16.99 kB = 5.61 kB 4.12 kB
facebook-www/SchedulerPostTaskOnly-dev.classic.js = 24.22 kB 17.62 kB = 6.41 kB 4.96 kB
facebook-www/SchedulerPostTaskOnly-dev.modern.js = 24.22 kB 17.62 kB = 6.41 kB 4.96 kB
facebook-www/SchedulerMock-dev.classic.js = 23.92 kB 17.32 kB = 5.69 kB 4.20 kB
facebook-www/SchedulerMock-dev.modern.js = 23.92 kB 17.32 kB = 5.69 kB 4.20 kB
oss-experimental/scheduler/cjs/scheduler.development.js = 22.20 kB 16.07 kB = 5.98 kB 4.55 kB
oss-stable/scheduler/cjs/scheduler.development.js = 22.20 kB 16.07 kB = 5.98 kB 4.55 kB
facebook-react-native/scheduler/cjs/Scheduler-dev.js = 22.29 kB 16.12 kB = 5.98 kB 4.55 kB
oss-experimental/scheduler/cjs/scheduler-unstable_post_task_only.development.js = 21.75 kB 15.64 kB = 5.91 kB 4.49 kB
oss-stable/scheduler/cjs/scheduler-unstable_post_task_only.development.js = 21.75 kB 15.64 kB = 5.91 kB 4.49 kB
facebook-react-native/scheduler/cjs/Scheduler-profiling.js = 14.12 kB 10.10 kB = 3.47 kB 2.60 kB
facebook-www/Scheduler-profiling.classic.js = 16.46 kB 11.37 kB = 3.85 kB 2.86 kB
facebook-www/Scheduler-profiling.modern.js = 16.46 kB 11.37 kB = 3.85 kB 2.86 kB
facebook-react-native/scheduler/cjs/SchedulerNoDOM-profiling.js = 12.57 kB 8.55 kB = 3.04 kB 2.15 kB
facebook-www/SchedulerPostTaskOnly-profiling.classic.js = 15.70 kB 10.63 kB = 3.71 kB 2.72 kB
facebook-www/SchedulerPostTaskOnly-profiling.modern.js = 15.70 kB 10.63 kB = 3.71 kB 2.72 kB
oss-experimental/scheduler/cjs/scheduler-unstable_no_dom.development.js = 18.89 kB 12.76 kB = 4.91 kB 3.44 kB
oss-stable/scheduler/cjs/scheduler-unstable_no_dom.development.js = 18.89 kB 12.76 kB = 4.91 kB 3.44 kB
facebook-react-native/scheduler/cjs/SchedulerNoDOM-dev.js = 18.90 kB 12.73 kB = 4.91 kB 3.42 kB
facebook-www/SchedulerNoDOM-dev.classic.js = 19.68 kB 13.05 kB = 5.00 kB 3.51 kB
facebook-www/SchedulerNoDOM-dev.modern.js = 19.68 kB 13.05 kB = 5.00 kB 3.51 kB
facebook-www/SchedulerNoDOM-profiling.classic.js = 13.90 kB 8.80 kB = 3.24 kB 2.23 kB
facebook-www/SchedulerNoDOM-profiling.modern.js = 13.90 kB 8.80 kB = 3.24 kB 2.23 kB

Generated by 🚫 dangerJS against 8e50058

@bvaughn bvaughn force-pushed the cleanup-scheduler-sampling-profiler branch from 72f3857 to d01743c Compare February 18, 2021 15:04
@bvaughn bvaughn force-pushed the cleanup-scheduler-sampling-profiler branch from d01743c to 8e50058 Compare February 18, 2021 15:06
@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 18, 2021

Turns out this is being used within FB so I'm going to close this PR.

@bvaughn bvaughn closed this Feb 18, 2021
@bvaughn bvaughn deleted the cleanup-scheduler-sampling-profiler branch February 18, 2021 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants