[DevTools] Handle case when cached network requests have null content in response #22282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #22198 we added support for listening for network requests for JavaScript source files and caching those requests, using the
network.onRequestFinished
api, in order to speed up downloading source files when attempting to extract hook names for an inspected element.However, the cached requests might sometimes return null content for the network response (e.g. here), which we weren't handling correctly. When the content was null, we'd end up with a runtime error by trying to access a property on the null object.
This commit makes it so we never use response content that is null by making sure to fall back to fetching the file normally if we are unable to obtain non-null content for a cached request.
Test Plan