Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert the outer module object to an object #26093

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Revert the outer module object to an object #26093

merged 2 commits into from
Feb 2, 2023

Commits on Feb 2, 2023

  1. Revert the outer module object to an object 

    This is because Webpack has a typeof ... === 'object' before its esm compat
test.

This is unfortunate because it means we can't have a nice error in CJS when
someone does this:

const fn = require('client-fn');
fn();

I also fixed some checks in the validator that read off the client ref. It
shouldn't do those checks against a client ref, since those now throw.
    @sebmarkbage
    sebmarkbage committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    cc33070 View commit details
    Browse the repository at this point in the history

  2. For some reason Babel doesn't like this syntax

    @sebmarkbage
    sebmarkbage committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    dfef627 View commit details
    Browse the repository at this point in the history