Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Webpack References by encoding file path + export name as single id #26300

Merged
merged 2 commits into from
Mar 5, 2023
Merged

Simplify Webpack References by encoding file path + export name as single id #26300

merged 2 commits into from
Mar 5, 2023

Commits on Mar 3, 2023

  1. Simplify Webpack References by encoding file path + export name as si… 

    …ngle id

We always look up these references in a map so it doesn't matter what their
value is. It could be a hash for example.

The loaders now encode a single $$id instead of filepath + name.

This changes the react-client-manifest to have a single level. The value
inside the map is still split into module id + export name because that's
what gets looked up in webpack.

The react-ssr-manifest is still two levels because that's a reverse lookup.
    @sebmarkbage
    sebmarkbage committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6448839 View commit details
    Browse the repository at this point in the history

  2. Rename ServerReferenceMetadata type to ServerReferenceId

    @sebmarkbage
    sebmarkbage committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    7936faa View commit details
    Browse the repository at this point in the history