Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codemod redundant async act scopes #26350

Merged
merged 1 commit into from
Mar 8, 2023

Commits on Mar 8, 2023

  1. Codemod redundant async act scopes

    Prior to facebook#26347, our internal `act` API (not the public API) behaved
    differently depending on whether the scope function returned a promise
    (i.e. was an async function), for historical reasons that no longer
    apply. Now that this is fixed, I've codemodded all async act scopes that
    don't contain an await to be sync.
    
    No pressing motivation other than it looks nicer and the codemod was
    easy. Might help avoid confusion for new contributors who see async act
    scopes with nothing async inside and infer it must be like that for
    a reason.
    acdlite committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    1be3edb View commit details
    Browse the repository at this point in the history