Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Float] support fetchpriority on ReactDOM.preload() and ReactDOM.preinit() #26880

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

gnoff
Copy link
Collaborator

@gnoff gnoff commented May 31, 2023

exposes fetchPriority as an option for ReactDOM.preload() and ReactDOM.preinit()

the typings should be 'high' | 'low' | 'auto'

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels May 31, 2023
@react-sizebot
Copy link

react-sizebot commented May 31, 2023

Comparing: ae31d2e...67441f9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.05% 164.28 kB 164.37 kB +0.02% 51.79 kB 51.80 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.05% 171.72 kB 171.81 kB +0.02% 54.02 kB 54.03 kB
facebook-www/ReactDOM-prod.classic.js +0.03% 570.52 kB 570.67 kB +0.01% 100.66 kB 100.68 kB
facebook-www/ReactDOM-prod.modern.js +0.03% 554.26 kB 554.41 kB +0.01% 97.84 kB 97.85 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 67441f9

@gnoff gnoff force-pushed the float-fetchpriority branch 3 times, most recently from e5c2ed4 to 0cbcc01 Compare May 31, 2023 22:03
@gnoff gnoff changed the title Float fetchpriority [Float] support fetchpriority on ReactDOM.preload() and ReactDOM.preinit() May 31, 2023
@gnoff
Copy link
Collaborator Author

gnoff commented Jun 1, 2023

cc @eps1lon TS type should be updated. Do you mind updating? If you can't I'll try to PR

@gnoff gnoff merged commit 042d8f6 into facebook:main Jun 1, 2023
@gnoff gnoff deleted the float-fetchpriority branch June 1, 2023 20:10
github-actions bot pushed a commit that referenced this pull request Jun 1, 2023
…reinit()` (#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`

DiffTrain build for [042d8f6](042d8f6)
@eps1lon
Copy link
Collaborator

eps1lon commented Jun 10, 2023

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…reinit()` (facebook#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…reinit()` (#26880)

exposes fetchPriority as an option for `ReactDOM.preload()` and
`ReactDOM.preinit()`

the typings should be `'high' | 'low' | 'auto'`

DiffTrain build for commit 042d8f6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants