Remove unused/redundant variables from Scheduler implementation #27130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is always `true` now, so we can delete it.
This is always `flushWork` so we can just call that directly.
facebook-github-bot
added
CLA Signed
React Core Team
tjallingt
reviewed
Jul 20, 2023
| callback: (hasTimeRemaining: boolean, initialTime: number) => boolean, | ||
| ) { | ||
| scheduledHostCallback = callback; | ||
| function requestHostCallback(callback: (initialTime: number) => boolean) { |
There was a problem hiding this comment.
- function requestHostCallback(callback: (initialTime: number) => boolean) {
+ function requestHostCallback() {Now flushWork is called directly but its still passed as the argument to requestHostCallback everywhere but its unused.
PR here #27133
noahlemen
pushed a commit
that referenced
this pull request
Jul 20, 2023
Noticed this argument was left in the cleanup from #27130 It seems to me like it would benefit from being cleaned up too.
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 8, 2023
Updated React from 9377e1010 to cb3404a0c. ### React upstream changes - facebook/react#27190 - facebook/react#27189 - facebook/react#27201 - facebook/react#27147 - facebook/react#26949 - facebook/react#27058 - facebook/react#27142 - facebook/react#27133 - facebook/react#27130 - facebook/react#27105 - facebook/react#27117 - facebook/react#27057
jerrydev0927
added a commit
to jerrydev0927/react
that referenced
this pull request
Jan 5, 2024
Noticed this argument was left in the cleanup from facebook/react#27130 It seems to me like it would benefit from being cleaned up too. DiffTrain build for [587ae49d71f218d34393291933d513d2975e22c3](facebook/react@587ae49)
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…book#27130) Tidying up some redundant code left from previous iterations of the implementation
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
…book#27133) Noticed this argument was left in the cleanup from facebook#27130 It seems to me like it would benefit from being cleaned up too.
bigfootjon
pushed a commit
that referenced
this pull request
Apr 18, 2024
Tidying up some redundant code left from previous iterations of the implementation DiffTrain build for commit 899cb95.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidying up some redundant code left from previous iterations of the implementation