Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fizz] Various smaller refactors #27368

Merged
merged 4 commits into from
Sep 13, 2023
Merged

[Fizz] Various smaller refactors #27368

merged 4 commits into from
Sep 13, 2023

Conversation

sebmarkbage
Copy link
Collaborator

Back ported from a larger PR.

@sebmarkbage
rm extra ;
6a4cb73 
The compiled code ends with one.
@sebmarkbage
Clarify ResumableNode types
b1317ce 
The parent nodes are ReplayNodes and the terminal nodes are Resumable points.
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 13, 2023
@react-sizebot
Copy link

react-sizebot commented Sep 13, 2023 •
edited
Loading

Comparing: 69be472...6c9271d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 166.38 kB 166.38 kB = 52.08 kB 52.08 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 175.64 kB 175.64 kB = 54.88 kB 54.88 kB
facebook-www/ReactDOM-prod.classic.js = 571.59 kB 571.59 kB = 100.62 kB 100.62 kB
facebook-www/ReactDOM-prod.modern.js = 555.37 kB 555.37 kB = 97.74 kB 97.74 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactDOMServer-prod.modern.js +0.29% 155.75 kB 156.20 kB +0.16% 28.38 kB 28.42 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.29% 157.90 kB 158.35 kB +0.13% 29.33 kB 29.37 kB

Generated by 🚫 dangerJS against 6c9271d

@sebmarkbage sebmarkbage merged commit e520565 into facebook:main Sep 13, 2023
36 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 13, 2023
@sebmarkbage
[Fizz] Various smaller refactors (#27368)
a1e1701 
Back ported from a larger PR.

DiffTrain build for [e520565](e520565)
@acdlite acdlite mentioned this pull request Sep 14, 2023
Merged
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
49dcc74 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
2361578 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8.
7e8e320 
React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Sep 14, 2023
@acdlite
Update React from dd480ef92 to d6dcad6a8. (#55399)
6f2e9ae 
### React upstream changes:

- facebook/react#27374
- facebook/react#27369
- facebook/react#27372
- facebook/react#27371
- facebook/react#27370
- facebook/react#27321
- facebook/react#27368
- facebook/react#27367
- facebook/react#27366
- facebook/react#27360
- facebook/react#27361
- facebook/react#27357
- facebook/react#27359
- facebook/react#27358
- facebook/react#27330
- facebook/react#27347
- facebook/react#27307
- facebook/react#27346
- facebook/react#27342
- facebook/react#27340
- facebook/react#27328
- facebook/react#27327
- facebook/react#27325
- facebook/react#27337
- facebook/react#27336
- facebook/react#27323
- facebook/react#27320
- facebook/react#27317
- facebook/react#27318
- facebook/react#27316
- facebook/react#27313
- facebook/react#27309
- facebook/react#27302
- facebook/react#27297
- facebook/react#27295
- facebook/react#27305
- facebook/react#27215
- facebook/react#27304
- facebook/react#27067
- facebook/react#27179
- facebook/react#27278
- facebook/react#27277
- facebook/react#27282
- facebook/react#27230
- facebook/react#27260
- facebook/react#27270
- facebook/react#27273
- facebook/react#27268
- facebook/react#27269
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@sebmarkbage @AndyPengc12
[Fizz] Various smaller refactors (facebook#27368)
5e262e8 
Back ported from a larger PR.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@sebmarkbage
[Fizz] Various smaller refactors (#27368)
419e64c 
Back ported from a larger PR.

DiffTrain build for commit e520565.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @acdlite @facebook-github-bot