Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] Dedupe suspense boundaries when it has already been found earlier #27408

Merged
merged 1 commit into from
Sep 23, 2023

Conversation

sebmarkbage
Copy link
Collaborator

If we track a postponed SuspenseBoundary parent that we have to replay through before it has postponed and it postpones itself later, we need to upgrade it to a postponed replay boundary instead of adding two.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 23, 2023
@react-sizebot
Copy link

Comparing: 56b1447...4001382

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 166.66 kB 166.66 kB = 52.14 kB 52.14 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 176.10 kB 176.10 kB = 54.98 kB 54.97 kB
facebook-www/ReactDOM-prod.classic.js = 571.96 kB 571.96 kB = 100.66 kB 100.66 kB
facebook-www/ReactDOM-prod.modern.js = 555.68 kB 555.68 kB = 97.77 kB 97.77 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4001382

@sebmarkbage sebmarkbage merged commit 69728fd into facebook:main Sep 23, 2023
36 checks passed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…rlier (facebook#27408)

If we track a postponed SuspenseBoundary parent that we have to replay
through before it has postponed and it postpones itself later, we need
to upgrade it to a postponed replay boundary instead of adding two.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…rlier (#27408)

If we track a postponed SuspenseBoundary parent that we have to replay
through before it has postponed and it postpones itself later, we need
to upgrade it to a postponed replay boundary instead of adding two.

DiffTrain build for commit 69728fd.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants