Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React DevTools 4.28.3 -> 4.28.4 #27419

Merged
merged 1 commit into from
Sep 25, 2023
Merged

React DevTools 4.28.3 -> 4.28.4 #27419

merged 1 commit into from
Sep 25, 2023

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Sep 25, 2023

  • refactor[devtools/extension]: refactored messaging logic across different parts of the extension (hoxyq in #27417)
  • fix[devtools/extension]: added a workaround for proxy content script injection in firefox (hoxyq in #27375)
  • fix[devtools/useTransition]: don't check for dispatch property when determining if hook is stateful (hoxyq in #27365)
  • feat[devtools/extension]: show disclaimer when page doesnt run react and refactor react polling logic (hoxyq in #27373)
  • feat:-Added a delete all filters action and added title to the add filter a… (Biki-das in #27332)
  • fix[devtools/extension]: unregister dynamically injected content scripts instead of filtering (hoxyq in #27369)
  • refactor[devtools/extension]: more stable element updates polling to avoid timed out errors (hoxyq in #27357)
  • feat[devtools/extension]: add dark theme for popup (rakleed in #27330)

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Sep 25, 2023
@hoxyq hoxyq merged commit 94d5b5b into facebook:main Sep 25, 2023
36 checks passed
@hoxyq hoxyq deleted the devtools/release/4.28.4 branch September 25, 2023 17:24
acdlite added a commit to acdlite/next.js that referenced this pull request Sep 29, 2023
@acdlite
Update React from 09285d5a7 to d900fadbf.
b8445db 
React upstream changes:

- facebook/react#27439
- facebook/react#26763
- facebook/react#27434
- facebook/react#27433
- facebook/react#27424
- facebook/react#27428
- facebook/react#27427
- facebook/react#27315
- facebook/react#27314
- facebook/react#27400
- facebook/react#27421
- facebook/react#27419
- facebook/react#27418
@acdlite acdlite mentioned this pull request Sep 29, 2023
Closed
@gnoff gnoff mentioned this pull request Sep 29, 2023
Merged
kodiakhq bot pushed a commit to vercel/next.js that referenced this pull request Oct 3, 2023
@gnoff
App Router - preinitialize chunks during SSR (#54752)
09b0ca4 
Today when we hydrate an SSR'd RSC response on the client we encounter import chunks which initiate code loading for client components. However we only start fetching these chunks after hydration has begun which is necessarily after the initial chunks for the entrypoint have loaded.

React has upstream changes that need to land which will preinitialize the rendered chunks for all client components used during the SSR pass. This will cause a `<script async="" src... />` tag to be emitted in the head for each chunk we need to load during hydration which allows the browser to start fetching these resources even before the entrypoint has started to execute.

Additionally the implementation for webpack and turbopack is different enough that there will be a new `react-server-dom-turbopack` package in the React repo which should be used when using Turbopack with Next.

This PR also removes a number of patches to React src that proxy loading (`__next_chunk_load__`) and bundler requires (`__next_require__`) through the `globalThis` object. Now the react packages can be fully responsible for implementing chunk loading and all Next needs to do is supply the necessary information such as chunk prefix and crossOrigin attributes necessary for this loading. This information is produced as part of the client-manifest by either a Webpack plugin or Turbopack.

Additionally any modifications to the chunk filename that were previously done at runtime need to be made in the manifest itself now. This means we need to encode the deployment id for skew protection and encode the filename to make it match our static path matching (and resolutions on s3) when using `[` and `]` segment characters.

There are a few followup items to consider in later PRs
1. we currently bundle a node and edge version of react-server-dom-webpack/client. The node version has an implementation for busboy whereas the edge version does not. Next is currently configured to use busboy when handling a fetch action sent as multipart with a node runtime. Ideally we'd only bundle the one platform we are buliding for but some additional refactoring to support better forking is possibly required here

This PR also updates react from 09285d5a7 to d900fadbf.

### React upstream changes

- facebook/react#27439
- facebook/react#26763
- facebook/react#27434
- facebook/react#27433
- facebook/react#27424
- facebook/react#27428
- facebook/react#27427
- facebook/react#27315
- facebook/react#27314
- facebook/react#27400
- facebook/react#27421
- facebook/react#27419
- facebook/react#27418
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@hoxyq @AndyPengc12
React DevTools 4.28.3 -> 4.28.4 (facebook#27419)
a51a9f1 
* refactor[devtools/extension]: refactored messaging logic across
different parts of the extension ([hoxyq](https:/hoxyq) in
[facebook#27417](facebook#27417))
* fix[devtools/extension]: added a workaround for proxy content script
injection in firefox ([hoxyq](https:/hoxyq) in
[facebook#27375](facebook#27375))
* fix[devtools/useTransition]: don't check for dispatch property when
determining if hook is stateful ([hoxyq](https:/hoxyq) in
[facebook#27365](facebook#27365))
* feat[devtools/extension]: show disclaimer when page doesnt run react
and refactor react polling logic ([hoxyq](https:/hoxyq) in
[facebook#27373](facebook#27373))
* feat:-Added a delete all filters action and added title to the add
filter a… ([Biki-das](https:/Biki-das) in
[facebook#27332](facebook#27332))
* fix[devtools/extension]: unregister dynamically injected content
scripts instead of filtering ([hoxyq](https:/hoxyq) in
[facebook#27369](facebook#27369))
* refactor[devtools/extension]: more stable element updates polling to
avoid timed out errors ([hoxyq](https:/hoxyq) in
[facebook#27357](facebook#27357))
* feat[devtools/extension]: add dark theme for popup
([rakleed](https:/rakleed) in
[facebook#27330](facebook#27330))
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@hoxyq
React DevTools 4.28.3 -> 4.28.4 (#27419)
4d382e1 
* refactor[devtools/extension]: refactored messaging logic across
different parts of the extension ([hoxyq](https:/hoxyq) in
[#27417](#27417))
* fix[devtools/extension]: added a workaround for proxy content script
injection in firefox ([hoxyq](https:/hoxyq) in
[#27375](#27375))
* fix[devtools/useTransition]: don't check for dispatch property when
determining if hook is stateful ([hoxyq](https:/hoxyq) in
[#27365](#27365))
* feat[devtools/extension]: show disclaimer when page doesnt run react
and refactor react polling logic ([hoxyq](https:/hoxyq) in
[#27373](#27373))
* feat:-Added a delete all filters action and added title to the add
filter a… ([Biki-das](https:/Biki-das) in
[#27332](#27332))
* fix[devtools/extension]: unregister dynamically injected content
scripts instead of filtering ([hoxyq](https:/hoxyq) in
[#27369](#27369))
* refactor[devtools/extension]: more stable element updates polling to
avoid timed out errors ([hoxyq](https:/hoxyq) in
[#27357](#27357))
* feat[devtools/extension]: add dark theme for popup
([rakleed](https:/rakleed) in
[#27330](#27330))

DiffTrain build for commit 94d5b5b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoxyq @facebook-github-bot