Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB-specific builds of Flight Server, Flight Client, and React Shared Subset #27579

Merged
merged 37 commits into from
Nov 27, 2023

Conversation

alunyov
Copy link
Contributor

@alunyov alunyov commented Oct 25, 2023

This PR adds a new FB-specific configuration of Flight. We also need to bundle a version of ReactSharedSubset that will be used for running Flight on the server.

This initial implementation does not support server actions yet.

The FB-Flight still uses the text protocol on the server (the flag enableBinaryFlight is set to false). It looks like we need some changes in Hermes to properly support this binary format.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Oct 25, 2023
@react-sizebot
Copy link

react-sizebot commented Oct 25, 2023

Comparing: aec521a...faa9d19

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 175.90 kB 175.90 kB = 54.75 kB 54.75 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 177.97 kB 177.97 kB = 55.39 kB 55.39 kB
facebook-www/ReactDOM-prod.classic.js = 569.81 kB 569.81 kB = 100.29 kB 100.29 kB
facebook-www/ReactDOM-prod.modern.js = 553.67 kB 553.67 kB = 97.38 kB 97.38 kB
facebook-www/ReactFlightDOMClient-dev.modern.js +∞% 0.00 kB 38.63 kB +∞% 0.00 kB 8.94 kB
facebook-www/ReactFlightDOMClient-prod.modern.js +∞% 0.00 kB 19.88 kB +∞% 0.00 kB 4.64 kB
facebook-www/ReactFlightDOMServer-dev.modern.js +∞% 0.00 kB 80.69 kB +∞% 0.00 kB 17.16 kB
facebook-www/ReactFlightDOMServer-prod.modern.js +∞% 0.00 kB 38.58 kB +∞% 0.00 kB 8.67 kB
facebook-www/ReactSharedSubset-dev.modern.js +∞% 0.00 kB 116.73 kB +∞% 0.00 kB 26.57 kB
facebook-www/ReactSharedSubset-prod.modern.js +∞% 0.00 kB 15.53 kB +∞% 0.00 kB 4.13 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactFlightDOMClient-dev.modern.js +∞% 0.00 kB 38.63 kB +∞% 0.00 kB 8.94 kB
facebook-www/ReactFlightDOMClient-prod.modern.js +∞% 0.00 kB 19.88 kB +∞% 0.00 kB 4.64 kB
facebook-www/ReactFlightDOMServer-dev.modern.js +∞% 0.00 kB 80.69 kB +∞% 0.00 kB 17.16 kB
facebook-www/ReactFlightDOMServer-prod.modern.js +∞% 0.00 kB 38.58 kB +∞% 0.00 kB 8.67 kB
facebook-www/ReactSharedSubset-dev.modern.js +∞% 0.00 kB 116.73 kB +∞% 0.00 kB 26.57 kB
facebook-www/ReactSharedSubset-prod.modern.js +∞% 0.00 kB 15.53 kB +∞% 0.00 kB 4.13 kB

Generated by 🚫 dangerJS against faa9d19

@alunyov alunyov force-pushed the FBFlightConfigMaybe branch 3 times, most recently from a0881f8 to 3c73a3d Compare November 12, 2023 01:44
@alunyov alunyov changed the title [Not Ready For Review] Fb flight config. Maybe. FB-specific builds of Flight Server, Flight Client, and React Shared Subset Nov 15, 2023
@alunyov alunyov marked this pull request as ready for review November 15, 2023 12:49
Copy link
Contributor

@josephsavona josephsavona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, accepting to unblock experimentation

@alunyov alunyov merged commit c17a27e into facebook:main Nov 27, 2023
36 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 27, 2023
…Subset (#27579)

This PR adds a new FB-specific configuration of Flight. We also need to
bundle a version of ReactSharedSubset that will be used for running
Flight on the server.

This initial implementation does not support server actions yet.

The FB-Flight still uses the text protocol on the server (the flag
`enableBinaryFlight` is set to false). It looks like we need some
changes in Hermes to properly support this binary format.

DiffTrain build for [c17a27e](c17a27e)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…Subset (facebook#27579)

This PR adds a new FB-specific configuration of Flight. We also need to
bundle a version of ReactSharedSubset that will be used for running
Flight on the server.

This initial implementation does not support server actions yet.

The FB-Flight still uses the text protocol on the server (the flag
`enableBinaryFlight` is set to false). It looks like we need some
changes in Hermes to properly support this binary format.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…Subset (#27579)

This PR adds a new FB-specific configuration of Flight. We also need to
bundle a version of ReactSharedSubset that will be used for running
Flight on the server.

This initial implementation does not support server actions yet.

The FB-Flight still uses the text protocol on the server (the flag
`enableBinaryFlight` is set to false). It looks like we need some
changes in Hermes to properly support this binary format.

DiffTrain build for commit c17a27e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants