Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated methods from react-is #28224

Merged
merged 2 commits into from
Feb 11, 2024
Merged

Remove deprecated methods from react-is #28224

merged 2 commits into from
Feb 11, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Feb 3, 2024

These aren't being used anywhere and don't even correspond to real APIs.

@react-sizebot
Copy link

Comparing: 3d6fcf9...5a18899

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.57 kB 176.57 kB = 55.00 kB 55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 178.69 kB 178.69 kB = 55.64 kB 55.64 kB
facebook-www/ReactDOM-prod.classic.js = 591.32 kB 591.32 kB = 104.34 kB 104.34 kB
facebook-www/ReactDOM-prod.modern.js = 575.08 kB 575.08 kB = 101.43 kB 101.43 kB
facebook-www/ReactIs-prod.classic.js = 5.36 kB 5.26 kB = 1.31 kB 1.28 kB
facebook-www/ReactIs-prod.modern.js = 5.36 kB 5.26 kB = 1.31 kB 1.28 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.85 kB 4.74 kB = 1.20 kB 1.17 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.85 kB 4.74 kB = 1.20 kB 1.17 kB
oss-experimental/react-is/cjs/react-is.production.js = 6.58 kB 6.39 kB = 1.78 kB 1.74 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 6.55 kB 6.37 kB = 1.77 kB 1.74 kB
oss-stable/react-is/cjs/react-is.production.js = 6.55 kB 6.37 kB = 1.77 kB 1.74 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.39 kB 2.31 kB = 0.89 kB 0.87 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.35 kB 2.27 kB = 0.88 kB 0.86 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.35 kB 2.27 kB = 0.88 kB 0.86 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.33 kB 2.24 kB = 0.81 kB 0.78 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.29 kB 2.21 kB = 0.80 kB 0.77 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.29 kB 2.21 kB = 0.80 kB 0.77 kB
oss-experimental/react-is/umd/react-is.development.js = 7.91 kB 6.96 kB = 2.09 kB 1.87 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.88 kB 6.94 kB = 2.08 kB 1.87 kB
oss-stable/react-is/umd/react-is.development.js = 7.88 kB 6.94 kB = 2.08 kB 1.87 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.31 kB 6.41 kB = 1.99 kB 1.78 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.28 kB 6.38 kB = 1.99 kB 1.78 kB
oss-stable/react-is/cjs/react-is.development.js = 7.28 kB 6.38 kB = 1.99 kB 1.78 kB
facebook-www/ReactIs-dev.classic.js = 8.49 kB 7.42 kB = 2.06 kB 1.84 kB
facebook-www/ReactIs-dev.modern.js = 8.49 kB 7.42 kB = 2.06 kB 1.83 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 8.10 kB 7.04 kB = 2.00 kB 1.77 kB
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactIs-prod.classic.js = 5.36 kB 5.26 kB = 1.31 kB 1.28 kB
facebook-www/ReactIs-prod.modern.js = 5.36 kB 5.26 kB = 1.31 kB 1.28 kB
facebook-react-native/react-is/cjs/ReactIs-prod.js = 4.85 kB 4.74 kB = 1.20 kB 1.17 kB
facebook-react-native/react-is/cjs/ReactIs-profiling.js = 4.85 kB 4.74 kB = 1.20 kB 1.17 kB
oss-experimental/react-is/cjs/react-is.production.js = 6.58 kB 6.39 kB = 1.78 kB 1.74 kB
oss-stable-semver/react-is/cjs/react-is.production.js = 6.55 kB 6.37 kB = 1.77 kB 1.74 kB
oss-stable/react-is/cjs/react-is.production.js = 6.55 kB 6.37 kB = 1.77 kB 1.74 kB
oss-experimental/react-is/umd/react-is.production.min.js = 2.39 kB 2.31 kB = 0.89 kB 0.87 kB
oss-stable-semver/react-is/umd/react-is.production.min.js = 2.35 kB 2.27 kB = 0.88 kB 0.86 kB
oss-stable/react-is/umd/react-is.production.min.js = 2.35 kB 2.27 kB = 0.88 kB 0.86 kB
oss-experimental/react-is/cjs/react-is.production.min.js = 2.33 kB 2.24 kB = 0.81 kB 0.78 kB
oss-stable-semver/react-is/cjs/react-is.production.min.js = 2.29 kB 2.21 kB = 0.80 kB 0.77 kB
oss-stable/react-is/cjs/react-is.production.min.js = 2.29 kB 2.21 kB = 0.80 kB 0.77 kB
oss-experimental/react-is/umd/react-is.development.js = 7.91 kB 6.96 kB = 2.09 kB 1.87 kB
oss-stable-semver/react-is/umd/react-is.development.js = 7.88 kB 6.94 kB = 2.08 kB 1.87 kB
oss-stable/react-is/umd/react-is.development.js = 7.88 kB 6.94 kB = 2.08 kB 1.87 kB
oss-experimental/react-is/cjs/react-is.development.js = 7.31 kB 6.41 kB = 1.99 kB 1.78 kB
oss-stable-semver/react-is/cjs/react-is.development.js = 7.28 kB 6.38 kB = 1.99 kB 1.78 kB
oss-stable/react-is/cjs/react-is.development.js = 7.28 kB 6.38 kB = 1.99 kB 1.78 kB
facebook-www/ReactIs-dev.classic.js = 8.49 kB 7.42 kB = 2.06 kB 1.84 kB
facebook-www/ReactIs-dev.modern.js = 8.49 kB 7.42 kB = 2.06 kB 1.83 kB
facebook-react-native/react-is/cjs/ReactIs-dev.js = 8.10 kB 7.04 kB = 2.00 kB 1.77 kB
test_utils/ReactAllWarnings.js Deleted 67.56 kB 0.00 kB Deleted 16.59 kB 0.00 kB

Generated by 🚫 dangerJS against 5a18899

@gaearon gaearon merged commit 35b2c28 into main Feb 11, 2024
36 checks passed
@gaearon gaearon deleted the rm-react-is-deprecations branch February 11, 2024 00:25
github-actions bot pushed a commit that referenced this pull request Feb 11, 2024
@gaearon
Remove deprecated methods from react-is (#28224)
9adade5 
These aren't being used anywhere and don't even correspond to real APIs.

DiffTrain build for [35b2c28](35b2c28)
This was referenced Feb 20, 2024
Closed
Merged
huozhi added a commit to vercel/next.js that referenced this pull request Feb 23, 2024
@huozhi
Upgrade vendored react (#62326)
e5d604f 
### React upstream changes

- facebook/react#28333
- facebook/react#28334
- facebook/react#28378
- facebook/react#28377
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269
- facebook/react#28376
- facebook/react#28338
- facebook/react#28331
- facebook/react#28336
- facebook/react#28320
- facebook/react#28317
- facebook/react#28375
- facebook/react#28367
- facebook/react#28380
- facebook/react#28368
- facebook/react#28343
- facebook/react#28355
- facebook/react#28374
- facebook/react#28362
- facebook/react#28344
- facebook/react#28339
- facebook/react#28353
- facebook/react#28346
- facebook/react#25790
- facebook/react#28352
- facebook/react#28326
- facebook/react#27688
- facebook/react#28329
- facebook/react#28332
- facebook/react#28340
- facebook/react#28327
- facebook/react#28325
- facebook/react#28324
- facebook/react#28309
- facebook/react#28310
- facebook/react#28307
- facebook/react#28306
- facebook/react#28315
- facebook/react#28318
- facebook/react#28226
- facebook/react#28308
- facebook/react#27563
- facebook/react#28297
- facebook/react#28286
- facebook/react#28284
- facebook/react#28275
- facebook/react#28145
- facebook/react#28301
- facebook/react#28224
- facebook/react#28152
- facebook/react#28296
- facebook/react#28294
- facebook/react#28279
- facebook/react#28273
- facebook/react#28269

Closes NEXT-2542


Disable ppr test for strict mode for now, @acdlite will check it and
we'll sync again
@ztanner ztanner mentioned this pull request Mar 19, 2024
Closed
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
@gaearon @AndyPengc12
Remove deprecated methods from react-is (facebook#28224)
cd26292 
These aren't being used anywhere and don't even correspond to real APIs.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
@gaearon
Remove deprecated methods from react-is (#28224)
2142970 
These aren't being used anywhere and don't even correspond to real APIs.

DiffTrain build for commit 35b2c28.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kassens kassens kassens approved these changes

@acdlite acdlite Awaiting requested review from acdlite

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaearon @react-sizebot @kassens @facebook-github-bot