Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the disableLegacyMode where ever we check the ConcurrentMode mode #28657

Merged
merged 6 commits into from
Apr 3, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Mar 27, 2024

Saves some bytes and ensures that we're actually disabling it.

Turns out this flag wasn't disabling React Native/Fabric, React Noop and React ART legacy modes so those are updated too.

Should be rebased on #28681.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Mar 27, 2024
@react-sizebot
Copy link

react-sizebot commented Mar 27, 2024

Comparing: 5998a77...2e729cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 176.81 kB 176.82 kB = 54.94 kB 54.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.69 kB 170.95 kB = 53.83 kB 53.31 kB
facebook-www/ReactDOM-prod.classic.js = 591.00 kB 591.01 kB = 103.63 kB 103.63 kB
facebook-www/ReactDOM-prod.modern.js = 573.22 kB 573.22 kB = 100.70 kB 100.70 kB
oss-experimental/react-art/umd/react-art.development.js = 957.85 kB 938.55 kB = 200.80 kB 197.37 kB
oss-experimental/react-art/cjs/react-art.development.js = 841.25 kB 822.70 kB = 181.43 kB 178.15 kB
test_utils/ReactAllWarnings.js Deleted 64.58 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler-reflection.development.js +0.69% 18.57 kB 18.70 kB +0.56% 5.34 kB 5.37 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler-reflection.development.js +0.53% 18.57 kB 18.67 kB +0.47% 5.34 kB 5.36 kB
oss-stable/react-reconciler/cjs/react-reconciler-reflection.development.js +0.53% 18.57 kB 18.67 kB +0.47% 5.34 kB 5.36 kB
oss-stable-semver/react/cjs/react.development.js +0.34% 99.60 kB 99.94 kB +0.34% 26.54 kB 26.63 kB
oss-stable/react/cjs/react.development.js +0.34% 99.63 kB 99.96 kB +0.33% 26.57 kB 26.66 kB
oss-stable-semver/react/umd/react.development.js +0.29% 122.24 kB 122.59 kB +0.31% 31.11 kB 31.21 kB
oss-stable/react/umd/react.development.js +0.29% 122.26 kB 122.62 kB +0.32% 31.14 kB 31.24 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.min.js = 179.63 kB 177.89 kB = 56.38 kB 55.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 172.69 kB 170.95 kB = 53.83 kB 53.31 kB
oss-experimental/react-dom/umd/react-dom.production.min.js = 172.51 kB 170.76 kB = 54.09 kB 53.56 kB
oss-experimental/react-dom/cjs/react-dom.profiling.min.js = 182.15 kB 180.19 kB = 56.22 kB 55.60 kB
oss-experimental/react-dom/umd/react-dom.profiling.min.js = 181.53 kB 179.55 kB = 56.40 kB 55.81 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js = 955.59 kB 944.27 kB = 215.52 kB 213.42 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 937.35 kB 926.02 kB = 211.00 kB 208.91 kB
oss-experimental/react-dom/cjs/react-dom.profiling.js = 979.15 kB 966.64 kB = 218.59 kB 216.29 kB
oss-experimental/react-art/umd/react-art.production.min.js = 135.52 kB 133.77 kB = 42.31 kB 41.73 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js = 1,343.18 kB 1,324.28 kB = 297.05 kB 293.63 kB
oss-experimental/react-dom/umd/react-dom.development.js = 1,388.57 kB 1,368.92 kB = 295.68 kB 292.24 kB
oss-experimental/react-dom/cjs/react-dom.development.js = 1,324.76 kB 1,305.86 kB = 292.64 kB 289.28 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.min.js = 112.82 kB 111.08 kB = 35.01 kB 34.45 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.min.js = 121.85 kB 119.89 kB = 37.29 kB 36.69 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 684.11 kB 672.79 kB = 150.22 kB 148.13 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js = 725.32 kB 712.81 kB = 157.65 kB 155.38 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js = 42.45 kB 41.71 kB = 9.63 kB 9.63 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js = 42.32 kB 41.58 kB = 9.62 kB 9.61 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.development.js = 858.01 kB 843.03 kB = 180.18 kB 177.36 kB
oss-experimental/react-art/cjs/react-art.production.min.js = 98.30 kB 96.57 kB = 30.21 kB 29.67 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js = 819.27 kB 804.77 kB = 178.06 kB 175.40 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.min.js = 104.75 kB 102.86 kB = 32.22 kB 31.55 kB
oss-experimental/react-test-renderer/umd/react-test-renderer.production.min.js = 105.04 kB 103.13 kB = 32.56 kB 31.87 kB
oss-experimental/react-art/cjs/react-art.production.js = 600.38 kB 589.08 kB = 133.99 kB 131.97 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js = 602.52 kB 590.91 kB = 134.72 kB 132.61 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.min.js = 15.64 kB 15.34 kB = 4.73 kB 4.69 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js = 36.29 kB 35.57 kB = 7.66 kB 7.66 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.min.js = 15.56 kB 15.26 kB = 4.71 kB 4.68 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js = 36.16 kB 35.44 kB = 7.65 kB 7.64 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js = 938.49 kB 919.77 kB = 201.07 kB 197.73 kB
oss-experimental/react-art/umd/react-art.development.js = 957.85 kB 938.55 kB = 200.80 kB 197.37 kB
oss-experimental/react-art/cjs/react-art.development.js = 841.25 kB 822.70 kB = 181.43 kB 178.15 kB
test_utils/ReactAllWarnings.js Deleted 64.58 kB 0.00 kB Deleted 16.14 kB 0.00 kB

Generated by 🚫 dangerJS against 2e729cc

@sebmarkbage sebmarkbage force-pushed the legacymode branch 8 times, most recently from e7021b8 to d13bb69 Compare March 27, 2024 06:15
sebmarkbage added a commit that referenced this pull request Apr 2, 2024
Pulling this out of #28657.

This runs react-art in concurrent mode if disableLegacyMode is true.
Effectively this means that the OSS version will be in concurrent mode
and the `.modern.js` version for Meta will be in concurrent mode, once
the flag flips for modern, but the `.classic.js` version for Meta will
be in legacy mode.

Updates flowing in from above flush synchronously so that they commit as
a unit. This also ensures that refs are resolved before the parent life
cycles. setStates deep in the tree will now be batched using "discrete"
priority but should still happen same task.
github-actions bot pushed a commit that referenced this pull request Apr 2, 2024
Pulling this out of #28657.

This runs react-art in concurrent mode if disableLegacyMode is true.
Effectively this means that the OSS version will be in concurrent mode
and the `.modern.js` version for Meta will be in concurrent mode, once
the flag flips for modern, but the `.classic.js` version for Meta will
be in legacy mode.

Updates flowing in from above flush synchronously so that they commit as
a unit. This also ensures that refs are resolved before the parent life
cycles. setStates deep in the tree will now be batched using "discrete"
priority but should still happen same task.

DiffTrain build for [5fcaa0a](5fcaa0a)
@sebmarkbage sebmarkbage force-pushed the legacymode branch 3 times, most recently from 8d5cba2 to 3d8f11c Compare April 3, 2024 00:45
@sebmarkbage sebmarkbage merged commit 5de8703 into facebook:main Apr 3, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 3, 2024
…#28657)

Saves some bytes and ensures that we're actually disabling it.

Turns out this flag wasn't disabling React Native/Fabric, React Noop and
React ART legacy modes so those are updated too.

Should be rebased on #28681.

DiffTrain build for [5de8703](5de8703)
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
Pulling this out of facebook#28657.

This runs react-art in concurrent mode if disableLegacyMode is true.
Effectively this means that the OSS version will be in concurrent mode
and the `.modern.js` version for Meta will be in concurrent mode, once
the flag flips for modern, but the `.classic.js` version for Meta will
be in legacy mode.

Updates flowing in from above flush synchronously so that they commit as
a unit. This also ensures that refs are resolved before the parent life
cycles. setStates deep in the tree will now be batched using "discrete"
priority but should still happen same task.
EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024
…facebook#28657)

Saves some bytes and ensures that we're actually disabling it.

Turns out this flag wasn't disabling React Native/Fabric, React Noop and
React ART legacy modes so those are updated too.

Should be rebased on facebook#28681.
bigfootjon pushed a commit that referenced this pull request Apr 18, 2024
…#28657)

Saves some bytes and ensures that we're actually disabling it.

Turns out this flag wasn't disabling React Native/Fabric, React Noop and
React ART legacy modes so those are updated too.

Should be rebased on #28681.

DiffTrain build for commit 5de8703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants