[tests] assertLog before act in ReactErrorBoundaries #28761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: a5aedd1...77cab71 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
|
Why do we sometimes clear instead of asserting on logs? |
|
@eps1lon for these test, many of the tests in this file are already clearing, and I think it's because the log is huge, like 20+ or more lines in many cases. We should probably re-write these to clean up the logs instead of logging everything always for all tests, but I don't have time for a full refactor. |
eps1lon
approved these changes
Apr 8, 2024
rickhanlonii
added a commit
that referenced
this pull request
Apr 10, 2024
rickhanlonii
added a commit
that referenced
this pull request
Apr 11, 2024
Fixes tests blocking #28737
rickhanlonii
added a commit
that referenced
this pull request
Apr 11, 2024
rickhanlonii
added a commit
that referenced
this pull request
Apr 11, 2024
Fixes tests blocking #28737
rickhanlonii
added a commit
that referenced
this pull request
Apr 11, 2024
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
Fixes tests blocking facebook#28737
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
We should force `assertLog` to be called before each `act` block to ensure the queue is empty. Requires fixing tests: - facebook#28745 - facebook#28758 - facebook#28759 - facebook#28760 - facebook#28761 - facebook#28762 - facebook#28763 - facebook#28812
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tests blocking #28737