[TestUtils] Build limited test-utils #28782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
eps1lon
approved these changes
Apr 8, 2024
| @@ -27,6 +27,7 @@ function getTestDocument(markup) { | |||
| } | |||
|
|
|||
| describe('ReactTestUtils', () => { | |||
| // @gate !disableDOMTestUtils | |||
| it('Simulate should have locally attached media events', () => { | |||
| expect(Object.keys(ReactTestUtils.Simulate).sort()).toMatchSnapshot(); | |||
There was a problem hiding this comment.
Need to switch to inline snapshots. Otherwise Jest thinks that the snapshot is obsolete and fails.
Suggested change
| expect(Object.keys(ReactTestUtils.Simulate).sort()).toMatchSnapshot(); | |
| expect(Object.keys(ReactTestUtils.Simulate).sort()).toMatchSnapshotInlineSnapshot(); |
…fork the entrypoint to make it work with tests properly
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
We landed a flag to disable test utils in many builds but we need to fork the entrypoint to make it work with tests properly. This also removes test-utils implementations from builds that do not support it. Currently in OSS builds the only thing in test-utils is a reexport of `act`
rickhanlonii
pushed a commit
that referenced
this pull request
Apr 11, 2024
We landed a flag to disable test utils in many builds but we need to fork the entrypoint to make it work with tests properly. This also removes test-utils implementations from builds that do not support it. Currently in OSS builds the only thing in test-utils is a reexport of `act`
EdisonVan
pushed a commit
to EdisonVan/react
that referenced
this pull request
Apr 15, 2024
We landed a flag to disable test utils in many builds but we need to fork the entrypoint to make it work with tests properly. This also removes test-utils implementations from builds that do not support it. Currently in OSS builds the only thing in test-utils is a reexport of `act`
This was referenced Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We landed a flag to disable test utils in many builds but we need to fork the entrypoint to make it work with tests properly. This also removes test-utils implementations from builds that do not support it. Currently in OSS builds the only thing in test-utils is a reexport of
act