Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flight] Encode ReadableStream and AsyncIterables #28847

Merged
merged 11 commits into from
Apr 16, 2024
Merged

[Flight] Encode ReadableStream and AsyncIterables #28847

merged 11 commits into from
Apr 16, 2024

Commits on Apr 16, 2024

  1. Add feature flag

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    60f5c61 View commit details
    Browse the repository at this point in the history

  2. Serialize ReadableStream and AsyncIterable

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7dd8e6f View commit details
    Browse the repository at this point in the history

  3. Propagate a cancel/abort signal to the serialized streams

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bed74ee View commit details
    Browse the repository at this point in the history

  4. Implement Consuming AsyncIterables

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    65f0172 View commit details
    Browse the repository at this point in the history

  5. Add a wrapper fragment if an AsyncIterable needs to be keyed 

    This is consistent with other Iterables.
    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    105fa03 View commit details
    Browse the repository at this point in the history

  6. Port sync resolution in thenables which are preinstrumented like Flight 

    This was already done in Fiber but not in Fizz/Flight.
    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e12febf View commit details
    Browse the repository at this point in the history

  7. Forward debug info to async iterables

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    f77a171 View commit details
    Browse the repository at this point in the history

  8. If a model is blocked on a direct dependency we need to wait to enque… 

    …ue it

For AsyncIterables, since we control the promises, we can instead let the
consumer peak ahead in that case.
    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    8e33e92 View commit details
    Browse the repository at this point in the history

  9. Try to synchronously emit a task if possible using the stream id 

    This helps us avoid outlining a model if it's synchronously available.
    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    cecd166 View commit details
    Browse the repository at this point in the history

  10. Emit root strings or typed arrays without outlining

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    e8d5dea View commit details
    Browse the repository at this point in the history

  11. Fix gates

    @sebmarkbage
    sebmarkbage committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    0fddb4e View commit details
    Browse the repository at this point in the history