Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build react-reconciler for FB builds #28880

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

sebmarkbage
Copy link
Collaborator

Meta uses various tools built on top of the "react-reconciler" package but that package needs to match the version of the "react" package.

This means that it should be synced at the same time. However, more than that the feature flags between the "react" package and the "react-reconciler" package needs to line up. Since FB has custom feature flags, it can't use the OSS version of react-reconciler.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 19, 2024
@react-sizebot
Copy link

Comparing: da6ba53...1d7cf8d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 168.91 kB 168.92 kB = 52.94 kB 52.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 170.57 kB 170.57 kB = 53.44 kB 53.44 kB
facebook-www/ReactDOM-prod.classic.js = 590.83 kB 590.83 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 566.65 kB 566.65 kB = 100.10 kB 100.10 kB
facebook-www/ReactReconciler-dev.classic.js +∞% 0.00 kB 1,189.96 kB +∞% 0.00 kB 229.87 kB
facebook-www/ReactReconciler-dev.modern.js +∞% 0.00 kB 1,155.65 kB +∞% 0.00 kB 223.66 kB
facebook-www/ReactReconciler-prod.classic.js +∞% 0.00 kB 455.09 kB +∞% 0.00 kB 73.34 kB
facebook-www/ReactReconciler-prod.modern.js +∞% 0.00 kB 437.42 kB +∞% 0.00 kB 70.77 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactReconciler-dev.classic.js +∞% 0.00 kB 1,189.96 kB +∞% 0.00 kB 229.87 kB
facebook-www/ReactReconciler-dev.modern.js +∞% 0.00 kB 1,155.65 kB +∞% 0.00 kB 223.66 kB
facebook-www/ReactReconciler-prod.classic.js +∞% 0.00 kB 455.09 kB +∞% 0.00 kB 73.34 kB
facebook-www/ReactReconciler-prod.modern.js +∞% 0.00 kB 437.42 kB +∞% 0.00 kB 70.77 kB
test_utils/ReactAllWarnings.js Deleted 64.44 kB 0.00 kB Deleted 16.10 kB 0.00 kB

Generated by 🚫 dangerJS against 1d7cf8d

@sebmarkbage sebmarkbage merged commit 446aa9a into facebook:main Apr 19, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 19, 2024
Meta uses various tools built on top of the "react-reconciler" package
but that package needs to match the version of the "react" package.

This means that it should be synced at the same time. However, more than
that the feature flags between the "react" package and the
"react-reconciler" package needs to line up. Since FB has custom feature
flags, it can't use the OSS version of react-reconciler.

DiffTrain build for [446aa9a](446aa9a)
jackpope added a commit that referenced this pull request May 6, 2024
In order to integrate the `react-reconciler` build created in #28880
with third party libraries, we need to have matching
`react-reconciler/constants` to go with it.
github-actions bot pushed a commit that referenced this pull request May 6, 2024
In order to integrate the `react-reconciler` build created in #28880
with third party libraries, we need to have matching
`react-reconciler/constants` to go with it.

DiffTrain build for [5d29478](5d29478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants