Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go back to shared refs instance object #28911

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Apr 25, 2024

It turns out we already made refs writable in #25696, which has been in canary for over a year. The approach in that PR also has the benefit of being slightly more perf sensitive because it still uses a shared object until the fiber is mounted. So let's just go back to that.

It turns out we already made refs writable in facebook#25696, which has been
in canary for over a year. The approach in that PR also has the benefit
of being slightly more perf sensitive because it still uses a shared
object until the fiber is mounted. So let's just go back to that.
@acdlite acdlite requested a review from kassens April 25, 2024 16:15
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 25, 2024
@react-sizebot
Copy link

Comparing: cf5ab8b...3727294

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.05% 1.82 kB 1.82 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.05% 1.83 kB 1.83 kB
facebook-www/ReactDOM-prod.classic.js = 591.14 kB 591.14 kB = 103.91 kB 103.91 kB
facebook-www/ReactDOM-prod.modern.js = 567.36 kB 567.36 kB = 100.30 kB 100.30 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react/cjs/react.production.js +0.22% 16.91 kB 16.95 kB +0.27% 4.39 kB 4.41 kB
oss-stable/react/cjs/react.production.js +0.22% 16.93 kB 16.97 kB +0.32% 4.42 kB 4.44 kB
oss-experimental/react/cjs/react.production.js +0.21% 18.06 kB 18.09 kB +0.32% 4.68 kB 4.70 kB
test_utils/ReactAllWarnings.js Deleted 64.26 kB 0.00 kB Deleted 16.02 kB 0.00 kB

Generated by 🚫 dangerJS against 3727294

@acdlite acdlite merged commit d285b3a into facebook:main Apr 25, 2024
38 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
It turns out we already made refs writable in #25696, which has been in
canary for over a year. The approach in that PR also has the benefit of
being slightly more perf sensitive because it still uses a shared object
until the fiber is mounted. So let's just go back to that.

DiffTrain build for commit d285b3a.
github-actions bot pushed a commit that referenced this pull request Apr 25, 2024
It turns out we already made refs writable in #25696, which has been in
canary for over a year. The approach in that PR also has the benefit of
being slightly more perf sensitive because it still uses a shared object
until the fiber is mounted. So let's just go back to that.

DiffTrain build for [d285b3a](d285b3a)
bigfootjon pushed a commit that referenced this pull request Apr 25, 2024
It turns out we already made refs writable in #25696, which has been in
canary for over a year. The approach in that PR also has the benefit of
being slightly more perf sensitive because it still uses a shared object
until the fiber is mounted. So let's just go back to that.

DiffTrain build for commit d285b3a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants