[compiler] Always emit variable decl in gating mode #29806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
This PR makes it so we always emit a const VariableDeclaration for compiled functions in gating mode. If the original declaration's parent was an ExportDefaultDeclaration we'll also append a new ExportDefaultDeclaration pointing to the new identifier. This allows code that adds optional properties to the function declaration to still work in gating mode ghstack-source-id: 54b8e4c19256dfcce52ae672cc3583490c6ddc57 Pull Request resolved: #29806
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 0a5e0b0...f4c2b1d Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
approved these changes
Jun 7, 2024
josephsavona
reviewed
Jun 7, 2024
...ugin-react-compiler/src/__tests__/fixtures/compiler/gating-preserves-function-properties.tsx
Show resolved
Hide resolved
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
This PR makes it so we always emit a const VariableDeclaration for compiled functions in gating mode. If the original declaration's parent was an ExportDefaultDeclaration we'll also append a new ExportDefaultDeclaration pointing to the new identifier. This allows code that adds optional properties to the function declaration to still work in gating mode ghstack-source-id: 5705479135baa268eeb3c85bfbf1883964e84916 Pull Request resolved: #29806
poteto
added a commit
that referenced
this pull request
Jun 7, 2024
This PR makes it so we always emit a const VariableDeclaration for compiled functions in gating mode. If the original declaration's parent was an ExportDefaultDeclaration we'll also append a new ExportDefaultDeclaration pointing to the new identifier. This allows code that adds optional properties to the function declaration to still work in gating mode ghstack-source-id: 5705479135baa268eeb3c85bfbf1883964e84916 Pull Request resolved: #29806
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
This PR makes it so we always emit a const VariableDeclaration for compiled functions in gating mode. If the original declaration's parent was an ExportDefaultDeclaration we'll also append a new ExportDefaultDeclaration pointing to the new identifier. This allows code that adds optional properties to the function declaration to still work in gating mode ghstack-source-id: 5705479135baa268eeb3c85bfbf1883964e84916 Pull Request resolved: #29806 DiffTrain build for commit 20841f9.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
This PR makes it so we always emit a const VariableDeclaration for compiled functions in gating mode. If the original declaration's parent was an ExportDefaultDeclaration we'll also append a new ExportDefaultDeclaration pointing to the new identifier. This allows code that adds optional properties to the function declaration to still work in gating mode ghstack-source-id: 5705479135baa268eeb3c85bfbf1883964e84916 Pull Request resolved: #29806 DiffTrain build for [20841f9](20841f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR makes it so we always emit a const VariableDeclaration for
compiled functions in gating mode. If the original declaration's parent
was an ExportDefaultDeclaration we'll also append a new
ExportDefaultDeclaration pointing to the new identifier. This allows
code that adds optional properties to the function declaration to still
work in gating mode