Minify DEV bundles with closure #29809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
|
The size diff is too large to display in a single comment. The CircleCI job contains an artifact called 'sizebot-message.md' with the full message. |
The goal is to improve speed of the development by inlining and DCE unused branches. We have the ability to preserve some variable names and pretty print in the production version so might as well do the same with DEV.
sebmarkbage
commented
Jun 7, 2024
| @@ -43,6 +43,7 @@ function willCoercionThrow(value: mixed): boolean { | |||
| } | |||
| } | |||
|
|
|||
| /** @noinline */ | |||
There was a problem hiding this comment.
This is a fun one. Closure doesn't think '' + can throw so it DCE this whole set of warnings. We'll have to watch out for stuff like that. Avoiding the inlining fixes that.
Luckily this was caught by build tests.
There was a problem hiding this comment.
Does Closure keep this comment? I remember we had a similar one in warning() but not sure if it’s gone now.
acdlite
approved these changes
Jun 7, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jun 8, 2024
The goal is to improve speed of the development by inlining and DCE unused branches. We have the ability to preserve some variable names and pretty print in the production version so might as well do the same with DEV. DiffTrain build for commit c2ae9e2.
This was referenced Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to improve speed of the development by inlining and DCE unused branches.
We have the ability to preserve some variable names and pretty print in the production version so might as well do the same with DEV.