[DevTools] Track the parent DevToolsInstance while mounting a tree #30542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sebmarkbage
commented
Jul 31, 2024
| @@ -2540,7 +2594,7 @@ export function attach( | |||
| updateFiberRecursively( | |||
| nextFallbackChildSet, | |||
| prevFallbackChildSet, | |||
| nextFiber, | |||
| newParentInstance, // Note this used to be the equivalent of fiberInstance if it was filtered but I think that was a bug. | |||
There was a problem hiding this comment.
I believe this is a bug fix because it shouldn't pass nextFiber as the parent if this node was filtered out.
The old code should've been shouldIncludeInTree ? nextFiber : parentFiber.
There was a problem hiding this comment.
Looks like a bug, I've shipped a fix some time ago for mounting case - #27147, which had shouldIncludeInTree ? nextFiber : parentFiber logic as well
hoxyq
approved these changes
Jul 31, 2024
| // Removes a Fiber (and its alternate) from the Maps used to track their id. | ||
| // This method should always be called when a Fiber is unmounting. | ||
| function untrackFiberID(fiber: Fiber) { | ||
| if (__DEBUG__) { | ||
| debug('untrackFiberID()', fiber, fiber.return, 'schedule after delay'); | ||
| debug('untrackFiberID()', fiber, null, 'schedule after delay'); |
There was a problem hiding this comment.
Why fiber.return is removed here? Because it should ideally point to DevToolsInstance, which can potentially be VirtualInstane?
There was a problem hiding this comment.
It’s a bit unclear what this is meant to help catch. This should be null already I believe. So is it meant to be like the previous parent?
There was a problem hiding this comment.
It’s a bit unclear what this is meant to help catch. This should be null already I believe. So is it meant to be like the previous parent?
Its kind of useless, I believe we just print it because of the spec of debug function. Could there be non-null reference to return Fiber? Is it guaranteed that return is going to be nullified for every Fiber in an unmounted branch by reconciler?
hoxyq
added a commit
that referenced
this pull request
Sep 25, 2024
Full list of changes: * refactor: data source for errors and warnings tracking is now in Store ([hoxyq](https:/hoxyq) in [#31010](#31010)) * fix: consider alternate as a key for componentLogsEntry when inspecting raw fiber instance ([hoxyq](https:/hoxyq) in [#31009](#31009)) * Fix: profiling crashes #30661 #28838 ([EdmondChuiHW](https:/EdmondChuiHW) in [#31024](#31024)) * chore: remove using local storage for persisting console settings on the frontend ([hoxyq](https:/hoxyq) in [#31002](#31002)) * feat: display message if user ended up opening hook script ([hoxyq](https:/hoxyq) in [#31000](#31000)) * feat: expose installHook with settings argument from react-devtools-core/backend ([hoxyq](https:/hoxyq) in [#30987](#30987)) * chore: remove settings manager from react-devtools-core ([hoxyq](https:/hoxyq) in [#30986](#30986)) * feat[react-devtools/extension]: use chrome.storage to persist settings across sessions ([hoxyq](https:/hoxyq) in [#30636](#30636)) * refactor[react-devtools]: propagate settings from global hook object to frontend ([hoxyq](https:/hoxyq) in [#30610](#30610)) * chore[react-devtools]: extract some utils into separate modules to unify implementations ([hoxyq](https:/hoxyq) in [#30597](#30597)) * refactor[react-devtools]: move console patching to global hook ([hoxyq](https:/hoxyq) in [#30596](#30596)) * refactor[react-devtools]: remove browserTheme from ConsolePatchSettings ([hoxyq](https:/hoxyq) in [#30566](#30566)) * feat[react-devtools]: add settings to global hook object ([hoxyq](https:/hoxyq) in [#30564](#30564)) * fix: add Error prefix to Error objects names ([hoxyq](https:/hoxyq) in [#30969](#30969)) * Add enableComponentPerformanceTrack Flag ([sebmarkbage](https:/sebmarkbage) in [#30960](#30960)) * fix[rdt/fiber/renderer.js]: getCurrentFiber can be injected as null ([hoxyq](https:/hoxyq) in [#30968](#30968)) * disable `enableSiblingPrerendering` in experimental channel ([gnoff](https:/gnoff) in [#30952](#30952)) * refactor[react-devtools]: initialize renderer interface early ([hoxyq](https:/hoxyq) in [#30946](#30946)) * Start prerendering Suspense retries immediately ([acdlite](https:/acdlite) in [#30934](#30934)) * refactor[Agent/Store]: Store to send messages only after Agent is initialized ([hoxyq](https:/hoxyq) in [#30945](#30945)) * refactor[RendererInterface]: expose onErrorOrWarning and getComponentStack ([hoxyq](https:/hoxyq) in [#30931](#30931)) * Implement getComponentStack and onErrorOrWarning for replayed Flight logs ([sebmarkbage](https:/sebmarkbage) in [#30930](#30930)) * Use Unicode Atom Symbol instead of Atom Emoji ([sebmarkbage](https:/sebmarkbage) in [#30832](#30832)) * Improve Layering Between Console and Renderer ([sebmarkbage](https:/sebmarkbage) in [#30925](#30925)) * Add Map for Server Component Logs ([sebmarkbage](https:/sebmarkbage) in [#30905](#30905)) * Delete fiberToFiberInstanceMap ([sebmarkbage](https:/sebmarkbage) in [#30900](#30900)) * Add Flight Renderer ([sebmarkbage](https:/sebmarkbage) in [#30906](#30906)) * Refactor Error / Warning Count Tracking ([sebmarkbage](https:/sebmarkbage) in [#30899](#30899)) * [flow] Upgrade Flow to 0.245.2 ([SamChou19815](https:/SamChou19815) in [#30919](#30919)) * Separate RDT Fusebox into single-panel entry points ([huntie](https:/huntie) in [#30708](#30708)) * Build Updater List from the Commit instead of Map ([sebmarkbage](https:/sebmarkbage) in [#30897](#30897)) * Simplify Context Change Tracking in Profiler ([sebmarkbage](https:/sebmarkbage) in [#30896](#30896)) * Remove use of .alternate in root and recordProfilingDurations ([sebmarkbage](https:/sebmarkbage) in [#30895](#30895)) * Handle reordered contexts in Profiler ([sebmarkbage](https:/sebmarkbage) in [#30887](#30887)) * Refactor Forcing Fallback / Error of Suspense / Error Boundaries ([sebmarkbage](https:/sebmarkbage) in [#30870](#30870)) * Avoid getFiberIDUnsafe in debug() Helper ([sebmarkbage](https:/sebmarkbage) in [#30878](#30878)) * Include some Filtered Fiber Instances ([sebmarkbage](https:/sebmarkbage) in [#30865](#30865)) * Track root instances in a root Map ([sebmarkbage](https:/sebmarkbage) in [#30875](#30875)) * Track all public HostInstances in a Map ([sebmarkbage](https:/sebmarkbage) in [#30831](#30831)) * Support VirtualInstances in findAllCurrentHostInstances ([sebmarkbage](https:/sebmarkbage) in [#30853](#30853)) * Add Filtering of Environment Names ([sebmarkbage](https:/sebmarkbage) in [#30850](#30850)) * Support secondary environment name when it changes ([sebmarkbage](https:/sebmarkbage) in [#30842](#30842)) * Increase max payload for websocket in standalone app ([runeb](https:/runeb) in [#30848](#30848)) * Filter Server Components ([sebmarkbage](https:/sebmarkbage) in [#30839](#30839)) * Track virtual instances on the tracked path for selections ([sebmarkbage](https:/sebmarkbage) in [#30802](#30802)) * Remove displayName from inspected data ([sebmarkbage](https:/sebmarkbage) in [#30841](#30841)) * chore[react-devtools/hook]: remove unused native values ([hoxyq](https:/hoxyq) in [#30827](#30827)) * chore[react-devtools/extensions]: remove unused storage permission ([hoxyq](https:/hoxyq) in [#30826](#30826)) * fix[react-devtools/extensions]: fixed tabs API calls and displaying restricted access popup ([hoxyq](https:/hoxyq) in [#30825](#30825)) * feat[react-devtools]: support Manifest v3 for Firefox extension ([hoxyq](https:/hoxyq) in [#30824](#30824)) * Reconcile Fibers Against Previous Children Instances ([sebmarkbage](https:/sebmarkbage) in [#30822](#30822)) * Remove findCurrentFiberUsingSlowPathByFiberInstance ([sebmarkbage](https:/sebmarkbage) in [#30818](#30818)) * Track Tree Base Duration of Virtual Instances ([sebmarkbage](https:/sebmarkbage) in [#30817](#30817)) * Use Owner Stacks to Implement View Source of a Server Component ([sebmarkbage](https:/sebmarkbage) in [#30798](#30798)) * Make function inspection instant ([sebmarkbage](https:/sebmarkbage) in [#30786](#30786)) * Make Functions Clickable to Jump to Definition ([sebmarkbage](https:/sebmarkbage) in [#30769](#30769)) * Support REACT_LEGACY_ELEMENT_TYPE for formatting JSX ([sebmarkbage](https:/sebmarkbage) in [#30779](#30779)) * Find owners from the parent path that matches the Fiber or ReactComponentInfo ([sebmarkbage](https:/sebmarkbage) in [#30717](#30717)) * [Flight/DevTools] Pass the Server Component's "key" as Part of the ReactComponentInfo ([sebmarkbage](https:/sebmarkbage) in [#30703](#30703)) * Hide props section if it is null ([sebmarkbage](https:/sebmarkbage) in [#30696](#30696)) * Support Server Components in Tree ([sebmarkbage](https:/sebmarkbage) in [#30684](#30684)) * fix[react-devtools/InspectedElement]: fixed border stylings when some of the panels are not rendered ([hoxyq](https:/hoxyq) in [#30676](#30676)) * Compute new reordered child set from the instance tree ([sebmarkbage](https:/sebmarkbage) in [#30668](#30668)) * Unmount instance by walking the instance tree instead of the fiber tree ([sebmarkbage](https:/sebmarkbage) in [#30665](#30665)) * Further Refactoring of Unmounts ([sebmarkbage](https:/sebmarkbage) in [#30658](#30658)) * Remove lodash.throttle ([sebmarkbage](https:/sebmarkbage) in [#30657](#30657)) * Unmount by walking previous nodes no longer in the new tree ([sebmarkbage](https:/sebmarkbage) in [#30644](#30644)) * Build up DevTools Instance Shadow Tree ([sebmarkbage](https:/sebmarkbage) in [#30625](#30625)) * chore[packages/react-devtools]: remove unused index.js ([hoxyq](https:/hoxyq) in [#30579](#30579)) * Track DOM nodes to Fiber map for HostHoistable Resources ([sebmarkbage](https:/sebmarkbage) in [#30590](#30590)) * Rename mountFiberRecursively/updateFiberRecursively ([sebmarkbage](https:/sebmarkbage) in [#30586](#30586)) * Allow Highlighting/Inspect HostSingletons/Hoistables and Resources ([sebmarkbage](https:/sebmarkbage) in [#30584](#30584)) * chore[react-devtools]: add global for native and use it to fork backend implementation ([hoxyq](https:/hoxyq) in [#30533](#30533)) * Enable pointEvents while scrolling ([sebmarkbage](https:/sebmarkbage) in [#30560](#30560)) * Make Element Inspection Feel Snappy ([sebmarkbage](https:/sebmarkbage) in [#30555](#30555)) * Track the parent DevToolsInstance while mounting a tree ([sebmarkbage](https:/sebmarkbage) in [#30542](#30542)) * Add DevToolsInstance to Store Stateful Information ([sebmarkbage](https:/sebmarkbage) in [#30517](#30517)) * Implement "best renderer" by taking the inner most matched node ([sebmarkbage](https:/sebmarkbage) in [#30494](#30494)) * Rename NativeElement to HostInstance in the Bridge ([sebmarkbage](https:/sebmarkbage) in [#30491](#30491)) * Rename Fiber to Element in the Bridge Protocol and RendererInterface ([sebmarkbage](https:/sebmarkbage) in [#30490](#30490)) * Stop filtering owner stacks ([sebmarkbage](https:/sebmarkbage) in [#30438](#30438)) * [Fiber] Call life-cycles with a react-stack-bottom-frame stack frame ([sebmarkbage](https:/sebmarkbage) in [#30429](#30429)) * [Flight] Prefix owner stacks added to the console.log with the current stack ([sebmarkbage](https:/sebmarkbage) in [#30427](#30427)) * [BE] switch to hermes parser for prettier ([kassens](https:/kassens) in [#30421](#30421)) * Implement Owner Stacks ([sebmarkbage](https:/sebmarkbage) in [#30417](#30417)) * [BE] upgrade prettier to 3.3.3 ([kassens](https:/kassens) in [#30420](#30420)) * [ci] Add yarn_test_build job to gh actions * [Fizz] Refactor Component Stack Nodes ([sebmarkbage](https:/sebmarkbage) in [#30298](#30298)) * Print component stacks as error objects to get source mapping ([sebmarkbage](https:/sebmarkbage) in [#30289](#30289)) * Upgrade flow to 0.235.0 ([kassens](https:/kassens) in [#30118](#30118)) * fix: path handling in react devtools ([Jack-Works](https:/Jack-Works) in [#29199](#29199))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just tracks the
.parentfield properly and uses DevToolsInstances in more places that used to use IDs or Fibers.I also use this new parent path when looking up a DevToolsInstance from a DOM node. This should ideally be simple because the
.parentfield represents only the unfiltered parents and include any virtual parents. So we should be able to just get one from nearest Fiber that has one.However, because we don't currently always clean up the map of DevToolsInstances (e.g. updateComponentFilters doesn't recursively clean out everything) it can leave matches hanging that shouldn't be there. So we need to run the shouldFilterFiber filter to ignore those.
Another interesting implication is that without a FiberInstance we don't have a way to get to a VirtualInstance from a HostComponent. Which means that even filtered Fibers need to have a FiberInstance if they have a VirtualInstance parent. Even if we don't actually mount them into the front-end.