Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Make Element Inspection Feel Snappy #30555

Merged
merged 2 commits into from
Aug 1, 2024
Merged

[DevTools] Make Element Inspection Feel Snappy #30555

merged 2 commits into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. Remove Suspense around InspectedElement 

    We should be just using the Transition value "inspectedElementID".

We could useDeferredValue but we already have an implementation of this
ID using a reducer but it would be more idiomatic to useDeferredValue.
    @sebmarkbage
    sebmarkbage committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8ee7311 View commit details
    Browse the repository at this point in the history

  2. Use queueMicrotask to batch bridge messages 

    This timeout is too long. It makes the UI feels sluggish.

Chrome also throttles looping timers aggressively which makes it worse.

We also shouldn't rely on the throttling at this level. It doesn't help
when you spam the receiving side with thousands of messages to process
anyway. Instead we need to implement a form of backpressure to avoid sending
so much in the first place.
    @sebmarkbage
    sebmarkbage committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c55b626 View commit details
    Browse the repository at this point in the history