Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flight] model halting as never delivered chunks #30740

Merged
merged 1 commit into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. [Flight] model halting as never delivered chunks

    We've refined the model of halting a prerender. Now when you abort during a prerender we simply omit the rows that would complete the flight render. This is analagous to prerendering in Fizz where you must resume the prerender to actually result in errors propagating in the postponed holes. We don't have a resume yet for flight and it's not entirely clear how that will work however the key insight here is that deciding whether the never resolving rows are an error or not should really be done on the consuming side rather than in the producer.
    
    This PR also reintroduces the logs for the abort error/postpone when prerendering which will give you some indication that something wasn't finished when the prerender was aborted.
    gnoff committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    cf8d1d1 View commit details
    Browse the repository at this point in the history