fix[react-devtools]: update profiling status before receiving response from backend #31117
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
hoxyq
force-pushed
the
react-devtools/optimistic-ui-for-profiler-button
branch
from
9fef1b1
to
8954a20
Compare
hoxyq
force-pushed
the
react-devtools/optimistic-ui-for-profiler-button
branch
from
8954a20
to
6845e0b
Compare
There was a problem hiding this comment.
Is there a risk of backend not being able to start profiling for some reason, then the UI would incorrectly show "it's profiling"?
Would it make sense to introduce additional states (other than boolean), e.g. "profiling", "start profiling requested by UI", "stop profiling requested by UI", "idle", etc. Can be done as a follow-up
Agree, this actually makes more sense. Will add it in a separate PR. |
There is a chance, if something wrong happened on the Backend side, and it didn't respond. We should refactor this to a single state and display the message to the user according to the current state, like "Starting a profiler..." -> "Recording..." -> "Stopping profiler..." -> "Collecting data..." -> Success |
#31118) Stacked on #31117. No need for sending long float numbers and to have resolution less than a microsecond, we end up formatting it on a Frontend side: https:/facebook/react/blob/6c7b41da3de12be2d95c60181b3fe896f824f13a/packages/react-devtools-shared/src/devtools/views/Profiler/utils.js#L359-L360
Changes in this release: * Fix React Compiler badging ([poteto](https:/poteto) in [#31196](#31196)) * fix[react-devtools]: fixed timeline profiler tests ([hoxyq](https:/hoxyq) in [#31261](#31261)) * fix[react-devtools]: record timeline data only when supported ([hoxyq](https:/hoxyq) in [#31154](#31154)) * refactor[react-devtools]: flatten reload and profile config ([hoxyq](https:/hoxyq) in [#31132](#31132)) * fix[react-devtools]: remove all listeners when Agent is shutdown ([hoxyq](https:/hoxyq) in [#31151](#31151)) * fix[react-devtools]: removed redundant startProfiling call ([hoxyq](https:/hoxyq) in [#31131](#31131)) * refactor[react-devtools/fiber/renderer]: optimize durations resolution ([hoxyq](https:/hoxyq) in [#31118](#31118)) * fix[react-devtools]: update profiling status before receiving response from backend ([hoxyq](https:/hoxyq) in [#31117](#31117)) * fix[react-devtools]: wrap key string in preformatted text html element ([hoxyq](https:/hoxyq) in [#31153](#31153)) * chore[react-devtools]: drop legacy context tests ([hoxyq](https:/hoxyq) in [#31059](#31059)) * chore[react-devtools]: add legacy mode error message to the ignore list for tests ([hoxyq](https:/hoxyq) in [#31060](#31060)) * fix[react-devtools]: request hook initialization inside http server response ([hoxyq](https:/hoxyq) in [#31102](#31102)) * [Flight] Serialize Server Components Props in DEV ([sebmarkbage](https:/sebmarkbage) in [#31105](#31105)) * Add: reload to profile for Fusebox ([EdmondChuiHW](https:/EdmondChuiHW) in [#31021](#31021)) * refactor: allow custom impl of backend realod-to-profile support check ([EdmondChuiHW](https:/EdmondChuiHW) in [#31048](#31048)) * fix: use public instance in Fiber renderer and expose it from getInspectorDataForViewAtPoint ([hoxyq](https:/hoxyq) in [#31068](#31068))
We can't wait for a response from Backend, because it might take some time to actually finish profiling.
We should keep a flag on the frontend side, so user can quickly see the feedback in the UI.