Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moar Warnings #3171

Merged
merged 3 commits into from
Feb 17, 2015
Merged

Moar Warnings #3171

merged 3 commits into from
Feb 17, 2015

Commits on Feb 17, 2015

  1. Warn if accessing .type on a factory 

    This was an important convenience as an upgrade path but shouldn't be
necessary if you're using best-practice of calling createFactory in the
consuming component.
    @sebmarkbage
    sebmarkbage committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    3587460 View commit details
    Browse the repository at this point in the history

  2. Warn if using Maps as children 

    We're not sure if this is the way we want to support this API. It creates
two ways of doing things.

It is convenient to avoid needing to explicitly redefine the key of Maps.
However, this use case isn't as common as having an iterable where the
key is on the value, not the key.
    @sebmarkbage
    sebmarkbage committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    9119412 View commit details
    Browse the repository at this point in the history

  3. Warn if getDOMNode or isMounted is accessed in render 

    This is an anti-pattern that can be easily avoided by putting the logic
in componentDidMount and componentDidUpdate instead.

It creates a dependency on stale data inside render without enforcing
a two-pass render.
    @sebmarkbage
    sebmarkbage committed Feb 17, 2015
    Configuration menu
    Copy the full SHA
    2490289 View commit details
    Browse the repository at this point in the history