Improve error boundaries tests #7569
Conversation
| container.innerHTML = ReactDOMServer.renderToString(<Boundary />); | ||
| expect(container.firstChild.innerHTML).toBe('Happy Birthday!'); | ||
| expect(EventPluginHub.putListener).not.toBeCalled(); | ||
| // note: renderToString does not call componentDidMount |
There was a problem hiding this comment.
Not sure why this even uses renderToString. Mind changing it to use ReactDOM.render so that we test the queueing behavior better? (See, I didn't even notice that the old test was testing the wrong thing but now that componentDidMount is completely absent here it's much more obvious. Thanks.)
There was a problem hiding this comment.
Should we have tests for both renderToString and ReactDOM.render? The title of this test block should be changed too if we're not testing SSR.
There was a problem hiding this comment.
In most cases it's fine to just test client rendering since the server codepath is mostly a subset of the client one.
There was a problem hiding this comment.
OK, updated the test to use ReactDOM.render instead. FYI, original test was introduced by #6694
|
lgtm otherwise, thanks! |
millermedeiros
force-pushed
the
boundarytest
branch
from
106008e
to
0c031c5
Compare
ghost
added
GH Review: review-needed
CLA Signed
and removed
GH Review: needs-revision
labels
|
this should be good to go, updated all the test to use |
|
Thanks! |
(cherry picked from commit 7d7defe)
this is kinda of a follow up to #7558 where @spicyj said:
the new tests makes sure the methods are executed in the proper order and don't rely on
EventPluginHubanymore - the'does not register event handlers for unmounted children'test still usesEventPluginHubsince it looks like it makes sense to leave that check there...also removed some parentheses and wrapped some lines.