Remove pendingUpdate optimization in ReactDOMSelect #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an optimization that avoids call update on ReactDOMSelect twice in an onChange event. facebook@2601b6a#commitcomment-19643403 None of the other controlled components do this. The only reason to do it here is because of the loop. I'd like to remove this because I'd like to remove all the side-effects that happen in onChange, other than user defined behavior. I'd also like to get rid of state that track sequences. It is easier if everything is just diffing. Alternatively I can store the previous value that we processed and only reprocess if the value has changed. However, that would requires the array for multiple values to be immutable and I don't think we enforce that right now. In Fiber, I believe that we'll be able to batch both these updates into a single commit.
sebmarkbage
commented
Nov 1, 2016
| expect(() => ReactTestUtils.Simulate.change(node)).not.toThrow( | ||
| "Cannot set property 'pendingUpdate' of null" | ||
| ); | ||
| expect(() => ReactTestUtils.Simulate.change(node)).not.toThrow(); |
There was a problem hiding this comment.
We should never test for absence of a particular error message since that might cover up errors when messages change.
sophiebits
approved these changes
Nov 1, 2016
|
I thought about this some more, it's worth checking whether focus still behaves correctly, i.e. does focusing it and selecting stuff via the keyboard still work correctly. Also, does anyone know why we're using |
acusti
pushed a commit
to brandcast/react
that referenced
this pull request
Mar 15, 2017
This removes an optimization that avoids call update on ReactDOMSelect twice in an onChange event. facebook@2601b6a#commitcomment-19643403 None of the other controlled components do this. The only reason to do it here is because of the loop. I'd like to remove this because I'd like to remove all the side-effects that happen in onChange, other than user defined behavior. I'd also like to get rid of state that track sequences. It is easier if everything is just diffing. Alternatively I can store the previous value that we processed and only reprocess if the value has changed. However, that would requires the array for multiple values to be immutable and I don't think we enforce that right now. In Fiber, I believe that we'll be able to batch both these updates into a single commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an optimization that avoids call update on ReactDOMSelect
twice in an onChange event.
2601b6a#commitcomment-19643403
None of the other controlled components do this. The only reason to do it
here is because of the loop.
I'd like to remove this because I'd like to remove all the side-effects
that happen in onChange, other than user defined behavior. I'd also like to
get rid of state that track sequences. It is easier if everything is just
diffing.
Alternatively I can store the previous value that we processed and only
reprocess if the value has changed. However, that would requires the array
for multiple values to be immutable and I don't think we enforce that
right now.
In Fiber, I believe that we'll be able to batch both these updates into a
single commit.