-
Notifications
You must be signed in to change notification settings - Fork 46.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate React.createMixin #8853
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,20 +35,35 @@ if (__DEV__) { | |
} | ||
|
||
var __spread = Object.assign; | ||
var createMixin = function(mixin) { | ||
return mixin; | ||
}; | ||
|
||
if (__DEV__) { | ||
var warned = false; | ||
var warnedForSpread = false; | ||
var warnedForCreateMixin = false; | ||
__spread = function() { | ||
warning( | ||
warned, | ||
warnedForSpread, | ||
'React.__spread is deprecated and should not be used. Use ' + | ||
'Object.assign directly or another helper function with similar ' + | ||
'semantics. You may be seeing this warning due to your compiler. ' + | ||
'See https://fb.me/react-spread-deprecation for more details.' | ||
); | ||
warned = true; | ||
warnedForSpread = true; | ||
return Object.assign.apply(null, arguments); | ||
}; | ||
|
||
createMixin = function(mixin) { | ||
warning( | ||
warnedForCreateMixin, | ||
'React.createMixin is deprecated and should not be used. You ' + | ||
'can use your mixin directly instead.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "You can use your mixin" sounds a bit aggressive, maybe "You can use this mixin"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed! |
||
); | ||
warnedForCreateMixin = true; | ||
return mixin; | ||
}; | ||
|
||
} | ||
|
||
var React = { | ||
|
@@ -75,10 +90,7 @@ var React = { | |
PropTypes: ReactPropTypes, | ||
createClass: ReactClass.createClass, | ||
createFactory: createFactory, | ||
createMixin: function(mixin) { | ||
// Currently a noop. Will be used to validate and trace mixins. | ||
return mixin; | ||
}, | ||
createMixin: createMixin, | ||
|
||
// This looks DOM specific but these are actually isomorphic helpers | ||
// since they are just generating DOM strings. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
/** | ||
* Copyright 2013-present, Facebook, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the BSD-style license found in the | ||
* LICENSE file in the root directory of this source tree. An additional grant | ||
* of patent rights can be found in the PATENTS file in the same directory. | ||
* | ||
* @emails react-core | ||
*/ | ||
|
||
'use strict'; | ||
|
||
describe('React', () => { | ||
|
||
var React; | ||
|
||
beforeEach(() => { | ||
React = require('React'); | ||
}); | ||
|
||
it('should log a deprecation warning once when using React.__spread', () => { | ||
spyOn(console, 'error'); | ||
React.__spread({}); | ||
React.__spread({}); | ||
expectDev(console.error.calls.count()).toBe(1); | ||
expectDev(console.error.calls.argsFor(0)[0]).toContain( | ||
'React.__spread is deprecated and should not be used' | ||
); | ||
}); | ||
|
||
it('should log a deprecation warning once when using React.createMixin', () => { | ||
spyOn(console, 'error'); | ||
React.createMixin(); | ||
React.createMixin(); | ||
expectDev(console.error.calls.count()).toBe(1); | ||
expectDev(console.error.calls.argsFor(0)[0]).toContain( | ||
'React.createMixin is deprecated and should not be used' | ||
); | ||
}); | ||
|
||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered adding some messaging here about mixins being considered harmful, but I'm not sure if that's overstepping since they're not actually considered deprecated.