Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add the warning if PropType function is called manually #8903

Merged
merged 3 commits into from
Feb 8, 2017

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Jan 31, 2017

With this change, now we again have the warning if you attempt to call PropTypes manually.

It was removed in #8066 but we shouldn't have done this since we still want to avoid people accidentally calling them in production (and even more so since now it would throw).

Fixes #8080.

…k#7132)""

This reverts commit be71f76.

In other words, now we again have the warning if you attempt to call PropTypes manually.
It was removed in facebook#8066 but we shouldn't have done this since we still want to avoid people accidentally calling them in production (and even more so since now it would throw).

Fixes facebook#8080.
@gaearon
Copy link
Collaborator Author

gaearon commented Feb 7, 2017

@spicyj Should be ready for review

Copy link
Collaborator

@sophiebits sophiebits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@gaearon gaearon merged commit 1d90894 into facebook:master Feb 8, 2017
@gaearon gaearon deleted the proptypes-warning-is-back branch February 8, 2017 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants