Temporarily add stack target to react-test-renderer bundle #9514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed an error in a temporary export property that had been added to the React object
Muwahahaha! |
gaearon
reviewed
Apr 25, 2017
| @@ -113,7 +113,7 @@ if (__DEV__) { | |||
| '(https://fb.me/migrating-from-react-proptypes)', | |||
| ); | |||
| warnedForCheckPropTypes = true; | |||
| return ReactPropTypes; | |||
| return checkPropTypes; | |||
There was a problem hiding this comment.
Did this typo get into any non-alpha release?
There was a problem hiding this comment.
Nope! I fat fingered it in PR #9399 in prep for alpha 10.
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Also fixed an error in a temporary export property that had been added to the React object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable a React-to-ReactNative sync that is currently blocked by a stack-compatible-only test renderer forked from PR #7516 that's used in fbsource. Once the changes proposed in #7516 have been made to test renderer this target can be removed from the bundle (and the forked renderer can be deleted as well).
This PR also fixes a typo in the temporary
checkPropTypesaccessor that that had been added to theReactobject previously.