rename react-addons-dom-factories to react-dom-factories
#9780
Conversation
**what is the change?:** `grep -r "react-addons-dom-factories" ./src` and the same in `./packages` then `%s /react-addons-dom-factories/react-dom-factories/gc` **why make this change?:** React dom factories were never part of the 'addons' and we want to minimize the whole 'addons' thing, since we are deprecating the `React.addons.*` API. **test plan:** `yarn test` and manually look at the README that was updated. **issue:** facebook#9398
|
Note to self: cherry-pick onto master |
flarnie
changed the title
react-addons-dom-factoriesreact-addons-dom-factories to react-dom-factories
Do we need to? I thought this package won't receive more updates. |
|
|
||
| ## Example | ||
|
|
||
| ```javascript | ||
| import ReactDOM from 'react-dom'; | ||
| import DOM from 'react-addons-dom-factories'; // ES6 | ||
| import DOM from 'react-dom-factories'; // ES6 |
There was a problem hiding this comment.
We can either remove // ES6 here or provide an ES5 example.
There was a problem hiding this comment.
oops - just noticed this. will fix.
I don't know. Let's figure it out. :)
You are correct. |
|
Ah okay. I thought we can just delete that folder for 16.0. |
|
I notice that both |
|
Not sure what you mean. Afaik this warning hasn't made it into any release. |
|
@NE-SmallTown might have seen that the warning was merged into master as well as 15.6, in #8356 so they are right that it's present in the latest unreleased 16.0-alpha. afaik we have not done an alpha-release of the 16 branch yet that includes that warning. So @gaearon is also correct. Instead of cherry-picking this onto master, we should do a commit that removes it and the warning both on the 16.0 branch. I'll open an issue to track that. (later this weekend probably) Also I expect to publish the |
|
Yea,I am using react 16 now.But you say 16 not includes this warning,I think this is not true because I get this warning. And I find the src code of this in the React.js file |
|
I believe you @NE-SmallTown - now I'm curious how it's happening. Which of the 16 alpha releases are you using? Or are you using a build directly from the react master branch? If you have pulled the recent React code directly from master any time after Apr. 24th then you would indeed get the inactionable warning. #8356 I think the latest alpha-release of 16.0 is https:/facebook/react/releases/tag/v16.0.0-alpha.3 and when I check the source code I don't see it there either. |
|
Alpha 3 is definitely not the latest, we released at least alpha 8 (and maybe more). I don't think we documented them anywhere but you can check what Generally alphas may contain unactionable warnings etc. We don't recommend anyone to use React alphas outside of React Native. |
I am using alpha-12.0.I don't specify concrete version,I just use
No,only when I learn fiber in the fiber-debugger directory I will do that.
Yea,don't worry,please trust that I am not blaming or complaining anyone or anything.I just want to experience fiber and some new features in advance. |
Remove a comment saying `es6`, since this is potentially unclear. We aren't contrasting to an es5 example here. Thanks to @gaearon for catching this in review of facebook#9780
**what is the change?:** `grep -r "react-addons-dom-factories" ./src` and the same in `./packages` then `%s /react-addons-dom-factories/react-dom-factories/gc` **why make this change?:** React dom factories were never part of the 'addons' and we want to minimize the whole 'addons' thing, since we are deprecating the `React.addons.*` API. **test plan:** `yarn test` and manually look at the README that was updated. **issue:** facebook#9398
what is the change?:
grep -r "react-addons-dom-factories" ./srcand the same in./packagesthen
%s /react-addons-dom-factories/react-dom-factories/gcwhy make this change?:
React dom factories were never part of the 'addons' and we want to minimize the
whole 'addons' thing, since we are deprecating the
React.addons.*API.test plan:
yarn testand manually look at the README that was updated.
issue:
#9398