Improve warning for React.createClass
#9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
May 25, 2017
src/isomorphic/React.js
Outdated
| 'Accessing createClass via the main React package is deprecated,' + | ||
| ' and will be removed in React v16.0.' + | ||
| " Use a plain JavaScript class instead. If you're not yet " + | ||
| 'ready to migrade, create-react-class v15.5.3 is available ' + |
There was a problem hiding this comment.
We can probably say v15 here because even if we release bugfixes we guarantee it's a drop in replacement anyway. And we want people to install fixes.
There was a problem hiding this comment.
Were there any issues with versions earlier than 15.3 though?
There was a problem hiding this comment.
Yes, probably. I just mean that we shouldn't give the impression that 15.5.3 is specific version to try because we know it's already broken (for AMD). We should recommend that they use the latest available 15.x version of create-react-class.
There was a problem hiding this comment.
Good point - will fix. Thanks!
gaearon
reviewed
May 26, 2017
src/isomorphic/React.js
Outdated
| @@ -112,8 +112,7 @@ if (__DEV__) { | |||
| didWarnPropTypesDeprecated, | |||
| 'Accessing PropTypes via the main React package is deprecated,' + | |||
| ' and will be removed in React v16.0.' + | |||
| ' Use the prop-types package from npm instead.' + | |||
| ' Version 15.5.10 provides a drop-in replacement.' + | |||
| ' Use the latest available 15.* prop-types package from npm instead.' + | |||
There was a problem hiding this comment.
Let's use v consistently in the message — either v15 or we can drop v from "React v16".
trueadm
approved these changes
May 26, 2017
petetnt
reviewed
May 29, 2017
src/isomorphic/React.js
Outdated
| 'Accessing createClass via the main React package is deprecated,' + | ||
| ' and will be removed in React v16.0.' + | ||
| " Use a plain JavaScript class instead. If you're not yet " + | ||
| 'ready to migrade, create-react-class v15.* is available ' + |
There was a problem hiding this comment.
Thanks!!! Will fix.
| 'Warning: Accessing createClass via the main React package is ' + | ||
| 'deprecated, and will be removed in React v16.0. ' + | ||
| 'Use a plain JavaScript class instead. ' + | ||
| "If you're not yet ready to migrade, create-react-class " + |
**what is the change?:** - Explain that this will be removed in v16.0 specifically - Mention the version number for the drop-in replacement module. - Link to docs in the blog post about how to migrate **why make this change?:** We want to make our deprecation warnings more clear and helpful. **test plan:** Visual inspection and `yarn test` **issue:** facebook#9398
**what is the change?:** Instead of recommending specific versions of 'prop-types' and 'create-react-class' we ask folks to use the latest available 15.* version. **why make this change?:** The latest version of those plugins, within the 15 version, is the most likely to be stable. For example, we know that 'react-create-class' is broken for AMD builds at the current latest version, so once we release a fix then the recommended version will change. **test plan:** Visual inspection Also fixed some tests.
**what is the change?:** - `migrade` -> `migrate` - `15.* prop-types package` -> `v15.* prop-types package` **why make this change?:** Correctness **test plan:** `yarn test` and visual inspection
flarnie
force-pushed
the
improveCreateClassDeprecationWarning
branch
from
59d2074
to
cf5aa32
Compare
flarnie
added a commit
to flarnie/react
that referenced
this pull request
Jun 7, 2017
* Improve warning for `React.createClass` **what is the change?:** - Explain that this will be removed in v16.0 specifically - Mention the version number for the drop-in replacement module. - Link to docs in the blog post about how to migrate **why make this change?:** We want to make our deprecation warnings more clear and helpful. **test plan:** Visual inspection and `yarn test` **issue:** facebook#9398 * Widen range of recommended replacement module versions **what is the change?:** Instead of recommending specific versions of 'prop-types' and 'create-react-class' we ask folks to use the latest available 15.* version. **why make this change?:** The latest version of those plugins, within the 15 version, is the most likely to be stable. For example, we know that 'react-create-class' is broken for AMD builds at the current latest version, so once we release a fix then the recommended version will change. **test plan:** Visual inspection Also fixed some tests. * Fix typos and things **what is the change?:** - `migrade` -> `migrate` - `15.* prop-types package` -> `v15.* prop-types package` **why make this change?:** Correctness **test plan:** `yarn test` and visual inspection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be the last PR to land for 15.6RC! 💫
what is the change?:
why make this change?:
We want to make our deprecation warnings more clear and helpful.
test plan:
Visual inspection and
yarn testissue:
#9398