Prepare react-dom-factories
for publishing
#9823
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what is the change?:
React.DOM.*
factory helpers into the package and wrapsthem with an IIFE
why make this change?:
We are deprecating
React.DOM.*
and this provides a fallback option forthose using it.
We just copied the code in order to avoid a circular dependency, which
keeps complexity down since we are supporting every possible build
system.
test plan:
DONE -
it works there.
TODO -
2. Do an initial publish of the package on npm and then pull it into
CRA, and try it there.
3. Try it in https:/duncanbeevers/jade-react or some other
project that actually uses the
React.DOM.*
helpers, using therelated codemod.
issue:
#9398