Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[runtime] Use globalThis before Function() #480

Merged
merged 1 commit into from
Jul 22, 2021
Merged

[runtime] Use globalThis before Function() #480

merged 1 commit into from
Jul 22, 2021

Conversation

nicolo-ribaudo
Copy link
Contributor

Fixes #450.

benjamn
benjamn approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nicolo-ribaudo!

@benjamn benjamn merged commit cc0cde9 into facebook:master Jul 22, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the globalthis branch July 22, 2021 19:03
@pankgeorg pankgeorg mentioned this pull request Nov 8, 2023
Closed
@felipebrahm felipebrahm mentioned this pull request Jan 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamn benjamn benjamn approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSP unsafe-eval in Web Worker in Chrome Browser which is always strict mode
3 participants
@nicolo-ribaudo @benjamn @facebook-github-bot