-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArenaTest.UnmappedAllocation fails when "transparent hugepage" is enabled. #12351
Comments
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this issue
Feb 23, 2024
Summary: ... by allocating in increments (1MiB) smaller than the typical smallest huge page size of 2MiB. Fixes facebook#12351 Test Plan: ``` sudo bash -c 'echo "always" > /sys/kernel/mm/transparent_hugepage/enabled' ``` And see unit test fails before this change, passes after this change
pdillinger
added a commit
to pdillinger/rocksdb
that referenced
this issue
Feb 23, 2024
Summary: ... by allocating in increments (1MiB) smaller than the typical smallest huge page size of 2MiB. Fixes facebook#12351 Test Plan: ``` sudo bash -c 'echo "always" > /sys/kernel/mm/transparent_hugepage/enabled' ``` And see unit test fails before this change, passes after this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
All tests pass on my desktop.
Actual behavior
ArenaTest.UnmappedAllocation fails. (It passes if I change THP to
madvise
ornever
).Steps to reproduce the behavior
Run the test case with THP enabled (
always
). On my friend's Ubuntu, he also need to setsysctl -w vm.nr_hugepages=256
to reproduce the failure.This test case expects on-demand Arena paging allocation (IIUC from the PR that introduced it), but seems, it needs to be composed conditionally based on OS, hardware's settings.
The text was updated successfully, but these errors were encountered: