Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate the copying of blobs when serving reads from the cache #10297

Closed
wants to merge 11 commits into from

Commits on Jul 1, 2022

  1. Eliminate the copying of blobs when serving reads from the cache

    Summary:
    
    The blob cache enables an optimization on the read path: when a blob is found in the cache, we can avoid copying it into the buffer provided by the application. Instead, we can simply transfer ownership of the cache handle to the target `PinnableSlice`. (Note: this relies on the `Cleanable` interface, which is implemented by `PinnableSlice`.)
    
    This has the potential to save a lot of CPU, especially with large blob values.
    gangliao committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    c4b8273 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Follow the comments

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    10f91dc View commit details
    Browse the repository at this point in the history
  2. Cleanup

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    6272052 View commit details
    Browse the repository at this point in the history
  3. Change to static_cast

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    3cc692e View commit details
    Browse the repository at this point in the history
  4. Add new TransferTo

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    1648db1 View commit details
    Browse the repository at this point in the history
  5. Fix clang-format

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4514dae View commit details
    Browse the repository at this point in the history
  6. Follow the comments

    gangliao committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    01c1d8f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Follow the comments

    gangliao committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    008bc9b View commit details
    Browse the repository at this point in the history
  2. Cleanup

    gangliao committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    558087e View commit details
    Browse the repository at this point in the history
  3. Follow the comments

    gangliao committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    4c75c32 View commit details
    Browse the repository at this point in the history
  4. Update ReleaseCacheHandle()

    gangliao committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    3369e7e View commit details
    Browse the repository at this point in the history