Synchronize statistic enumeration values between statistics.h and java API #2209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Copied from #2171 ).
Problem: The enumerations of tickers and histogram types for retrieving statistics are not in sync between the C++ source and the java API:
Java version:
https:/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/TickerType.java
https:/facebook/rocksdb/blob/master/java/src/main/java/org/rocksdb/HistogramType.java
C++ version:
https:/facebook/rocksdb/blob/master/include/rocksdb/statistics.h
The java Enumeration is missing a lot of declarations, and their values do not correspond to the (implicit) order of values in the C++ enum.
Impact: for example, retrieving the
BLOOM_FILTER_USEFUL
statistic through the java API, actually returns the data forBLOCK_CACHE_FILTER_MISS
.