Test: Update HistogramTypes in the Java API #2435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like appveyor builds are not getting scheduled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please disregard.
Creating this PR just to check if appveyor builds are getting kicked off for PR or not. Seems like they are not.
This diff syncs the Histogram Types in the Java API with the ones in C++ API (
statistics.h), and brings it up-to-date.I also found that the enum ordering between Java and C++ has gotten out-of-sync, a few years back, with the addition of
SUBCOMPACTION_SETUP_TIME. So updated the order as well.READ_NUM_MERGE_OPERANDSadded in #2373 is needed for Cassandra-on-RocksDB work.Test Plan:
I couldn't find any specific unit tests in Java to test this code. But, nevertheless,
make jtestexecutes fine.(Tests for 2429)