Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥🚒🧯 Put out the fire #593

Merged
merged 7 commits into from
Mar 3, 2022

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented Mar 2, 2022

All CI jobs are failing and building from source, caused by a change in the checksum of the csmith dependency.

As best as I can tell, this checksum change is innocuous. By simply updating the checksum all tests continue to pass. As a precaution I've added a secondary URL for csmith tarballs.

This PR also includes a handful of tiny fixes I found while testing the #590 mitigation using make test.

Fixes #590.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #593 (207dbb9) into development (f2ca6c2) will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #593      +/-   ##
===============================================
+ Coverage        88.16%   88.34%   +0.17%     
===============================================
  Files              114      114              
  Lines             6708     6708              
===============================================
+ Hits              5914     5926      +12     
+ Misses             794      782      -12     
Impacted Files Coverage Δ
compiler_gym/envs/compiler_env.py 92.32% <0.00%> (+0.49%) ⬆️
compiler_gym/envs/llvm/datasets/cbench.py 80.74% <0.00%> (+0.74%) ⬆️
compiler_gym/service/connection.py 79.01% <0.00%> (+0.98%) ⬆️
...loop_tool/service/loop_tool_compilation_session.py 91.15% <0.00%> (+3.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ca6c2...207dbb9. Read the comment docs.

@ChrisCummins ChrisCummins marked this pull request as ready for review March 2, 2022 22:03
Copy link
Contributor

@mostafaelhoushi mostafaelhoushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mostafaelhoushi mostafaelhoushi self-requested a review March 2, 2022 22:12
@ChrisCummins
Copy link
Contributor Author

CI/test-linux-cmake is failing because of a flaky timeout in unrelated test_validate_benchmark_semantics tests. Normally I would re-run but merging anyway to unblock other development 🤞

Cheers,
Chris

@ChrisCummins ChrisCummins merged commit 7f29360 into facebookresearch:development Mar 3, 2022
@ChrisCummins ChrisCummins deleted the fix/590 branch March 3, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[High priority] Building from source + all CI jobs failing, csmith archive checksum invalid
4 participants