Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary lines from benchmark examples #607

Conversation

mostafaelhoushi
Copy link
Contributor

Removed some lines that shouldn't have been in the benchmarks

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #607 (ea99005) into development (0a40983) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #607      +/-   ##
===============================================
+ Coverage        88.17%   88.28%   +0.10%     
===============================================
  Files              114      114              
  Lines             6708     6708              
===============================================
+ Hits              5915     5922       +7     
+ Misses             793      786       -7     
Impacted Files Coverage Δ
compiler_gym/views/observation_space_spec.py 85.71% <0.00%> (-3.58%) ⬇️
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 96.70% <0.00%> (-0.37%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 80.74% <0.00%> (+0.74%) ⬆️
...loop_tool/service/loop_tool_compilation_session.py 89.79% <0.00%> (+1.36%) ⬆️
compiler_gym/service/connection.py 80.00% <0.00%> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a40983...ea99005. Read the comment docs.

Copy link
Contributor

@ChrisCummins ChrisCummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mostafaelhoushi mostafaelhoushi merged commit 275414a into facebookresearch:development Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants