Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMake Linux for opt-loops #608

Merged
merged 6 commits into from
Mar 7, 2022
Merged

Fix CMake Linux for opt-loops #608

merged 6 commits into from
Mar 7, 2022

Conversation

mostafaelhoushi
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022 •
edited
Loading

Codecov Report

Merging #608 (0509377) into development (d5d60b6) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #608      +/-   ##
===============================================
- Coverage        88.26%   88.20%   -0.06%     
===============================================
  Files              114      114              
  Lines             6708     6708              
===============================================
- Hits              5921     5917       -4     
- Misses             787      791       +4
Impacted Files Coverage Δ
compiler_gym/views/observation_space_spec.py 85.71% <0.00%> (-3.58%) ⬇️
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
compiler_gym/envs/compiler_env.py 91.83% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d60b6...0509377. Read the comment docs.

@mostafaelhoushi mostafaelhoushi mentioned this pull request Mar 6, 2022
Open
@mostafaelhoushi
Copy link
Contributor Author

Happiness is when all the green CI signals are green!
image

@mostafaelhoushi mostafaelhoushi merged commit 9ffdd06 into facebookresearch:development Mar 7, 2022
ChrisCummins
ChrisCummins reviewed Mar 7, 2022
View reviewed changes
Copy link
Contributor

@ChrisCummins ChrisCummins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! 🎉

examples/loop_optimizations_service/service_py/loops_opt_service.py
@@ -35,7 +35,7 @@
from compiler_gym.third_party.autophase import AUTOPHASE_FEATURE_NAMES
from compiler_gym.third_party.inst2vec import Inst2vecEncoder
from compiler_gym.util.commands import run_command
from compiler_gym.util.runfiles_path import runfiles_path
from compiler_gym.util.runfiles_path import runfiles_path # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep this import?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisCummins ChrisCummins ChrisCummins left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mostafaelhoushi @codecov-commenter @ChrisCummins @facebook-github-bot