CompilerGym v0.2.3 #630
Merged
CompilerGym v0.2.3 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC refactoring of actions and observations
Co-authored-by: Chris Cummins <[email protected]>
[www] Sahir/UI/code_cleanup
CompilerEnv.step() currently accepts two types for the "action" argument: a scalar action, or an iterable of actions. This kind of type overloading does not work for list types. This adds a new method, CompilerEnv.multistep(), that explicitly takes takes an iterable sequence of actions. If you want to run multiple actions in a single step, call this new method. Calling CompilerEnv.step() with a list of actions still works, though with a deprecation warning. In the v0.2.4 release support for lists of actions in CompilerEnv.step() will be removed. Fixes #610.
This makes the following changes: - Changes env.step() `action` to accept only a single action, with a deprecation warning if a list of actions are provided. - Renames env.step() `observations` to `observation_spaces`. The old parameter name is still accepted with a deprecation warning. - Renames env.step() `rewards` to `reward_spaces`. The old parameter name is still accepted with a deprecation warning.
Using setup.py to install dependencies causes issues with some packages, like TensorFlow.
Add missing BUILD file for //compiler_gym/third_party/programl.
The makefile integration test is hardcoded to require llvm-11.
[examples] Split Makefile to be standalone and improve readme.
…n-list Split CompilerEnv.step() into two methods for singular or lists of actions (take 2)
…pec-errors [core] Better error message is proto is invalid.
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## stable #630 +/- ##
==========================================
+ Coverage 86.53% 88.50% +1.97%
==========================================
Files 113 115 +2
Lines 6393 7066 +673
==========================================
+ Hits 5532 6254 +722
+ Misses 861 812 -49
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release brings in deprecating changes to the core
env.step()routine, and lays the groundwork for enabling new types of compiler optimizations to be exposed through CompilerGym. Many thanks to code contributors: @mostafaelhoushi, @sogartar, @KyleHerndon, @uduse, @parthchadha, and @xtremey!Highlights of this release include:
TextSizeInBytesobservation space for LLVM (#575).createAndRunCompilerGymServicenow returns an int, which is the exit return code (#592).Deprecations and breaking changes:
CompilerEnv.stepno longer accepts a list of actions (#627). A new method,CompilerEnv.multistepprovides this functionality. This is to provide compatibility with environments whose action spaces are lists. To update your code, replace any calls toenv.step()which take a list of actions to useenv.multistep(). Thanks @sogartar!observationsandrewardstostep()have been renamedobservation_spacesandreward_spaces, respectively (#627).Reward.idhas been renamedReward.name(#565, #612). Thanks @parthchadha!Full Changelog: v0.2.2...v0.2.3