Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Pro Heroku option #757

Open
MrGemy95 opened this issue Apr 8, 2022 · 2 comments
Open

[Feature Request] Pro Heroku option #757

MrGemy95 opened this issue Apr 8, 2022 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@MrGemy95
Copy link

MrGemy95 commented Apr 8, 2022

Hi Everyone,

Is there any way to create a heroku server as pro directly from Mephisto?

@JackUrb
Copy link
Contributor

JackUrb commented Apr 8, 2022

We don't have an option for this right now, but I'd be happy to accept a PR that implements use_pro in the same way we have use_hobby.

Option:

use_hobby: bool = field(
default=False, metadata={"help": "Launch on the Heroku Hobby tier"}
)

Implementation:
if self.args.architect.use_hobby is True:
try:
subprocess.check_output(
shlex.split("{} dyno:type Hobby".format(heroku_executable_path))
)
except subprocess.CalledProcessError: # User doesn't have hobby access
self.__delete_heroku_server()
sh.rm(shlex.split("-rf {}".format(heroku_server_directory_path)))
raise Exception(
"Server launched with hobby flag but account cannot create "
"hobby servers."
)

@JackUrb JackUrb changed the title Pro Heroku [Feature Request] Pro Heroku option Apr 14, 2022
@JackUrb JackUrb added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 14, 2022
@Zekrom-7780
Copy link

@JackUrb can I work on this issue?

@meta-paul meta-paul removed the enhancement New feature or request label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants