Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build failing after poetry transition #874

Closed
pringshia opened this issue Jul 31, 2022 · 1 comment · Fixed by #917
Closed

Docker build failing after poetry transition #874

pringshia opened this issue Jul 31, 2022 · 1 comment · Fixed by #917

Comments

@pringshia
Copy link
Contributor

Seems like the Docker builds are failing after the implementation of #779

https:/facebookresearch/Mephisto/runs/7594956450?check_suite_focus=true#step:3:5

Output:

54
Step 8/10 : RUN cd /mephisto && pip install -e .
55
---> Running in c702111e0461
56
ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /mephisto
57
(A "pyproject.toml" file was found, but editable mode currently requires a setuptools-based build.)

@pringshia
Copy link
Contributor Author

pringshia commented Aug 15, 2022

Going to try looking into the pip version.

Seems to be a bug with the compiled Docker image (only node versions 15 and 10 failing).

We should manually upgrade pip in the Dockerfile to fix this issue. Perhaps:

python -m pip install pip

JackUrb added a commit that referenced this issue Oct 12, 2022
fix #874: Upgrade pip and create main_data_directory in Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant