Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heroku_architect.py #1062

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Update heroku_architect.py #1062

merged 2 commits into from
Oct 20, 2023

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Sep 13, 2023

Addressing #1060.

Uses a linear search rather than direct selection to get the first non-empty app name.

cc @gaotianyu1350

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (12bd642) 60.48% compared to head (59005bd) 60.46%.
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1062      +/-   ##
==========================================
- Coverage   60.48%   60.46%   -0.02%     
==========================================
  Files         155      155              
  Lines       11822    11825       +3     
==========================================
  Hits         7150     7150              
- Misses       4672     4675       +3
Files Coverage Δ
...phisto/abstractions/architects/heroku_architect.py 35.00% <0.00%> (-0.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JackUrb JackUrb added fix Small fixes and cleanups quick labels Sep 15, 2023
@facebook-github-bot
Copy link
Contributor

Hi @JackUrb!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@meta-paul
Copy link
Contributor

@JackUrb sorry this PR flew under the radar. Should I rebase it on dev prior to merging?

@JackUrb
Copy link
Contributor Author

JackUrb commented Oct 20, 2023

This fix can go straight to main

@meta-paul meta-paul merged commit 9fb0dec into main Oct 20, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meta-paul meta-paul meta-paul approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fix Small fixes and cleanups quick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JackUrb @codecov-commenter @facebook-github-bot @meta-paul