Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with remote procedure agent state preventing reload #763

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Apr 20, 2022

Overview

A bug with the load_data method prevented RemoteProcedureAgentStates from properly reloading data for a task review. This PR introduces the fix.

Testing

First, local testing in terminal. Now using right now in a live deploy

@JackUrb JackUrb requested a review from pringshia April 20, 2022 19:39
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2022

Codecov Report

Merging #763 (e88c798) into main (ccdc942) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #763      +/-   ##
==========================================
+ Coverage   64.23%   64.25%   +0.02%     
==========================================
  Files         107      107              
  Lines        9202     9205       +3     
==========================================
+ Hits         5911     5915       +4     
+ Misses       3291     3290       -1     
Impacted Files Coverage Δ
...s/remote_procedure/remote_procedure_agent_state.py 36.14% <0.00%> (-1.36%) ⬇️
mephisto/abstractions/architects/mock_architect.py 90.84% <0.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccdc942...e88c798. Read the comment docs.

@JackUrb JackUrb merged commit 8ad221c into main Apr 20, 2022
@JackUrb JackUrb deleted the remote-agent-state-fix branch April 20, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants