Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to poetry 1.2, resolving dependency issues #898

Merged
merged 8 commits into from
Oct 25, 2022

Conversation

JackUrb
Copy link
Contributor

@JackUrb JackUrb commented Aug 31, 2022

Overview

As titled, this PR upgrades the base version of poetry that the Mephisto project uses to 1.2. It also upgrades our ParlAI peer dependency to 1.7.0, however in the process drops support for python 3.7.

Discussion

Does dropping python 3.7 warrant moving to mephisto 1.1? I'm not sure where I land on this, though for now I've only bumped to 1.0.4 in this PR. @pringshia any thoughts?

Resolves #890

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #898 (6219e6c) into main (51a2b1d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   64.63%   64.62%   -0.01%     
==========================================
  Files         108      108              
  Lines        9320     9318       -2     
==========================================
- Hits         6024     6022       -2     
  Misses       3296     3296              
Impacted Files Coverage Δ
mephisto/data_model/unit.py 77.59% <0.00%> (-0.55%) ⬇️
...ractions/blueprints/mixins/screen_task_required.py 74.48% <0.00%> (-0.26%) ⬇️
mephisto/utils/metrics.py 29.32% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JackUrb JackUrb mentioned this pull request Aug 31, 2022
Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for setup problems or the tests failing? or both?

@mojtaba-komeili
Copy link
Contributor

Is this for setup problems or the tests failing? or both?

NM, just saw the issue addressing this. Thanks for the fix.

@JackUrb JackUrb changed the base branch from main to rich-print October 25, 2022 16:57
@JackUrb JackUrb changed the base branch from rich-print to main October 25, 2022 16:58
@JackUrb JackUrb merged commit a3cbb8c into main Oct 25, 2022
@JackUrb JackUrb deleted the poetry-version-upgrade branch October 25, 2022 21:40
@pringshia pringshia mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install Failed
4 participants