Refactoring QA from unit assign to use in onboarding #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
pringshia
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As noted in #959, passing onboarding led directly to a real unit, even if Screening (or Gold) units are configured. This PR resolves the issue.
Details
register_agentinto a separate_assign_unit_or_qafunction, so that it can also be called inregister_agent_from_onboarding.register_agent_from_onboardingin the rare case that a worker passes onboarding, and is only then no longer eligible for a unit due toget_valid_units_for_workerorfilter_units_for_worker- these used to be logged asNOT_QUALIFIEDbut are now appropriatelyNO_AVAILABLE_UNITS.Testing
Automated, reproducing the example in #959