Fix radius search with HSNW and IP #3698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D60373054 |
|
This pull request was exported from Phabricator. Differential Revision: D60373054 |
mdouze
added a commit
to mdouze/faiss
that referenced
this pull request
Jul 29, 2024
Summary: Pull Request resolved: facebookresearch#3698 Addressed issue facebookresearch#3684 I forgot to negate the threshold of the radius search. This diff adds a test and fixes the issue. Differential Revision: D60373054
Summary: Pull Request resolved: facebookresearch#3698 Addressed issue facebookresearch#3684 I forgot to negate the threshold of the radius search. This diff adds a test and fixes the issue. Reviewed By: mengdilin Differential Revision: D60373054
|
This pull request was exported from Phabricator. Differential Revision: D60373054 |
|
This pull request has been merged in 7178bf8. |
ketor
pushed a commit
to dingodb/faiss
that referenced
this pull request
Aug 20, 2024
Summary: Pull Request resolved: facebookresearch#3698 Addressed issue facebookresearch#3684 I forgot to negate the threshold of the radius search. This diff adds a test and fixes the issue. Reviewed By: mengdilin Differential Revision: D60373054 fbshipit-source-id: 70f3daa8292177a4038846a94aff6221f88077e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addressed issue
#3684
I forgot to negate the threshold of the radius search.
This diff adds a test and fixes the issue.
Differential Revision: D60373054