This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Feature/support dbt core1.7.x #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kudryk
changed the title
…ror as "mockTarget" is not created by ProjectTemporaryDirectory().
squat
reviewed
Apr 4, 2024
projects/adapter/tests/test_cli.py
Outdated
| @@ -252,7 +252,7 @@ def test_selection(capfd): | |||
|
|
|||
| def test_no_run_results(capfd): | |||
| with ProjectTemporaryDirectory() as tmp_dir: | |||
| shutil.rmtree(os.path.join(tmp_dir, "mockTarget")) | |||
| shutil.rmtree(os.path.join(tmp_dir, "mockTarget"), ignore_errors=True) | |||
There was a problem hiding this comment.
This seems sketchy! Why do we have to ignore errors?
There was a problem hiding this comment.
Perhaps I should have deleted the line instead. ProjectTemporaryDirectory() creates the temp directory but without mockTarget, yet rmtree will try to delete the entire tree assuming mockTarget exists, but as it doesn't, an exception is thrown. Unsure why this line was put there in the first place. I added ignore_errors as the rmtree API has been updated; perhaps this is a new python 3.11 behaviour.
There was a problem hiding this comment.
@squat I've updated this test to check for the directory's existence first.
kudryk
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is building upon the work @salimmoulouel started with PR #919. There's a fix to limit Google protobuf version which this project doesn't use but dbt-core does; dbt-core is fixing that in version 1.8; as this PR is still focused on 1.7.x I've added it here.
resolves
#909
#880
#914
Integration tests
Adapter to test:
Python version to test: